nicowilliams/heimdal — comment on commit 6fce54a5b1f68e3fb6007bb17da5038bb7eb8489
File: base/heimbase.h line 206
By nicowilliams:

I don't know if you get e-mail when I comment below your comments in
github. I've replied to all your comments, but this one I want to
make sure you don't miss:

On Fri, Dec 30, 2011 at 5:40 AM, Love Hörnquist Åstrand

wrote:
> please don't introduce another datatype, the ntlm, krb5, base, and asn1 have the same heim_data, lets not add one more
> if you need a const data, lets add that then in heimbase/asn1 and not in the db layer

There's a reason I added a new datatype here: to avoid data copies.

However, if we leave HDB out of this then maybe data copies are not a
concern, in that case I'll just change this to heim_data_t. What do
you think?

Nico
--