martine/ninja — comment on commit 8a0c96075786c1983bdfa2f37f32b75200ea0334
File: src/lexer.in.cc line 108
By martine:

Sorry! Pushed a fix (and an expanded test).

On Fri, Dec 30, 2011 at 3:01 PM, Nico Weber

wrote:
> varname is used in ReadIdent(). The old Tokenizer::ReadIdent() had a comment saying (search for IsIdentChar() in this diff)
>
> # ...use a table as generated by this Python script:
> # for c in string.ascii_letters + string.digits + r'+,-./\_$':
>
> So previously, +,-/\ were supported in idents too. Did you change this intentionally? gyp uses at least - pretty heavily (just run
>
> PATH=~/ninja:$PATH python gyptest.py -a -f ninja
>
> to check)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/martine/ninja/commit/8a0c96075786c1983bdfa2f37f32b75200ea0334#commitcomment-829000