boto/boto — comment on commit 8cf0e021660e63641629817343dab7a5b93f7941
File:  line 0
By tpodowd:

Mitch,

delete_keys() is a better name than delete_multiple(). Thanks. A couple of things about the patch.

1. Amazon docs say:
Quiet:
Element to enable quiet mode for the request. When you add this element, you must set its value to true

Therefore we should not add it if the setting is false as the new patch is currently doing.

2. DeleteMarker is not inherited from Key, so if the resultset contains a delete marker, its not possible to delete them.
It's really useful to be able to delete the delete markers also. They are really just special versions of the object,

3. I also like being able to pass a resultset straight from bucket.list_versions() or one of those combinations. Those resultsets can contain also the Prefix object. Instead of failing the whole request for this (since it makes no sense to try to delete a prefix object), I was skipping those.

4. I like the inclusion of the MultiDelete resultset object. I was considering that but was feeling a little lazy :-)

5. I didn't notice the unit tests. I'll add some if I get a chance in the new year.

Happy New Year!

Tom.