Ablu/manaserv — comment on commit 6fa410f8172426472d6360b707846f5eb478aa53
File:  line 0
By Bertram25:

Hi,

This patch sounds good, except the part where you added the function in the protocol file.
I'm not fond of adding this there because the file should limit itself about the protocol info used as much as possible.
Could you try to move the getGenderByInt() and getGenderByString() functions to the common/defines.h file for instance?
Plus, the name differentiation seems unneeded to me (I mean the ByInt and ByString part) since the actual function used can be determined by the parameter type: i.e.:
getGender(int x)
...
getGender(std::string x)

Thanks in advance!