techee/geany-patches — comment on commit 7951b695f797c2fbda5db02506e0b9125c9d42ac
File:  line 0
By elextr:

On Fri, Dec 30, 2011 at 8:58 AM, Jiří Techet

wrote:
> OK, I see - forget about this patch. However, in order to make the dialog a bit clearer, I'd suggest some more changes:
>
> * rename "Independent commands" to "Filetype independent commands" (for someone not familiar with the build system it's not clear independent of what the commands are)

I don't mind either way, better ask on the ML to see if anyone
supports/objects strongly.

>
> * add filetype to execute commands. As I understand it, execute commands are per-filetype and the current label makes impression that they are filetype-independent. So you'd get labels like "C execute commands".

Yes the dialog only edits filetype executes, but there has been
discussion of splitting execute into two groups, filetype and filetype
independent so both can be edited in the dialog.

>
> * is the documentation in the "Build menu configuration" section in the table at the "System filetype" x "Filetype independent" position? It says it gets the configuration from filetypes.xxx but filetype-independent entries shouldn't be in the filetypes.xxx files (I haven't checked the sources for this - it's just how I understand it)

The documentation is right. The groupings are mainly for human
consumption, the code will actually allow any command in any group,
see the wiki article at
http://wiki.geany.org/howtos/configurebuildmenu for more explanation
and some use cases.

>
> * I remember in the past we were talking about replacing the hardcoded dialog for "make custom target" with something like %c{enter custom text here} inside the command string. This would eliminate a bit the special cases in the dialog. Is something like that wanted? I could have a look at that.

Yes it was discussed, but my use-case disappeared and noone else
seemed to think it was worth doing. If you have a need feel free to
look at it and ask again in the ML. Note questions like having
multiple commands with %c and keeping separate sets of recently used
values.

>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/techee/geany-patches/commit/7951b695f797c2fbda5db02506e0b9125c9d42ac#commitcomment-827052