zackdouglas/sproutcore-ui — comment on commit 12a66a4c0a08f98b4b0cd2fbb8ba6b0a2eaff57c
File:  line 0
By zackdouglas:

Hi Luke,

I actually went ahead and pulled in some other changes that I needed from
another branch, https://github.com/ynniv/sproutcore-ui, as well. You can
see this merge at https://github.com/zackdouglas/sproutcore-ui

I also need to make an additional change to the time picker: That
particular view is ignoring any initial value for the selectedTime. (That
is, I have a `selectedTimeBinding: MyRecord.date` set.) When the time
picker loads, the initial value is ignored, and the results are two-fold:
1) The UI looks broken, as the time text field holds no value (empty), and
2) The backend can cause broken data if the user focuses the text field but
does not re-specify a value (thus causing the binding to nullify the record
field's value).

*Could you give a suggestion as to how you'd like me to go about addressing
this problem so that it would be welcomed as a pull request?* I'm comparing
the time picker widget to the date picker widget and I see some
customizations made in the `init:` function there.

After I have these problems fixed, I'll gladly write unit tests and
amend/re-submit the pull request!

Cheers,
Zackery Douglas

Ph: 724.312.2282
9404 Sunset Ct
Apt 418
Manassas Park, VA 20111

On Wed, Dec 28, 2011 at 9:58 AM, Luke Melia <
reply@reply.github.com
> wrote:

> Thanks, Zach. Any chance you could add a test for this?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/zackdouglas/sproutcore-ui/commit/12a66a4c0a08f98b4b0cd2fbb8ba6b0a2eaff57c#commitcomment-824249
>