alesj/LeanEngine-Android — comment on commit f779f27bf4c786a72d8e1f2c6fb6e04915348730
File:  line 0
By PeterKnego:

Hi Ales,

first of all: thank you in taking interest in our project and making effort to contributing to it.

I took a look at the patch and here are my findings:

1. I agree that ThreadSafeClientConnManager should be used.

2. AppEngine only supports ports 80 and 443, so setting ports should not be a an option for client.

3. Setting content charset would probably clash with code setting content directly to UTF-8: for example RestService.java:102. Client does not directly provide content, but rather all data is provided vis LeanEntity. So it makes no difference what is character encoding on protocol level.

4. We should probably use AndroidHttpClient instead of DefaultHttpClient as this provides sensible defaults for mobile devices and is recommended by Google.

If you agree I'd remove the port, sslport and charset configuration parameters and keep the rest?

I'm also interested if you use LeanEngine in a project? Do you find it useful? Any missing features? Any architectural mistakes that you'd change?

Again, thanks for your input.

Peter Knego