alesj/LeanEngine-Android — comment on commit f779f27bf4c786a72d8e1f2c6fb6e04915348730
File:  line 0
By alesj:

>> AppEngine only supports ports 80 and 443, so setting ports should not be a an option for client.

Actually, not really:
* http://code.google.com/appengine/docs/java/tools/devserver.html
You might wanna test your stuff before. :-)
(ok, you can change the GAE_local port ...)

>> Setting content charset would probably clash with code setting content directly to UTF-8: for example RestService.java:102. Client does not >> directly provide content, but rather all data is provided vis LeanEntity. So it makes no difference what is character encoding on protocol level.

You could read that 102 encoding from Configuration as well.

>> We should probably use AndroidHttpClient instead of DefaultHttpClient as this provides sensible defaults for mobile devices and is recommended by Google.

What does it add?
Or where is this recommended?

> If you agree I'd remove the port, sslport and charset configuration parameters and keep the rest?

Sure, it's your code, I just added an example patch. :-)

> I'm also interested if you use LeanEngine in a project? Do you find it useful?

I'm using my own stuff, which is pretty similar to yours:
* https://github.com/capedwarf/capedwarf-green

But I like your minimalistic approach, hence had a closer look.

> Any missing features?

It's a super small lib, so definitely. :-)
Check CapeDwarf's modules.

But I'll definitely have a look how to closely integrate with your stuff.
Did you manage to push lean-engine to some Maven repository yet?

> Any architectural mistakes that you'd change?

Didn't go into details, just saw this Pascal-like static RestService and couldn't resist fixing it. :-)

But let's discuss this over beer (since we live 20km away anyway :-))?