xbmc/xbmc — comment on commit d1c5773a2736849616adda4013d1a8c5a56a84e6
File: xbmc/music/karaoke/karaokevideobackground.h line 77
By jmarshallnz:

I suggest this patch series is reverted and done as a pull request so that
it can be reviewed prior to going into trunk. We don't want trunk to
break, and basically nothing non-trivial should be committed there without
first doing a pull request.

On Sat, Dec 17, 2011 at 6:33 PM, gyunaev <
reply@reply.github.com
> wrote:

> Too many ambiguous forward declarations, as besides those pointers it
> also needs AVFormatContext and the rest. All the headers which use this
> file include them except WinRenderer.h.
>
> > make these pointers, forward declare and new/delete them in the .cpp.
> Then you don't need to include them in the header and it keeps the include
> spew down.
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> https://github.com/xbmc/xbmc/commit/d1c5773a2736849616adda4013d1a8c5a56a84e6#commitcomment-802674
>
>
> --
> With best regards, George.
> http://www.kchmviewer.net - the first CHM files viewer for Qt/KDE.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/xbmc/xbmc/commit/d1c5773a2736849616adda4013d1a8c5a56a84e6#commitcomment-802767
>