mapbox/tilemill — comment on commit d9f9d82ac50630241ce022e7088a1a37716ca7cd
File:  line 0
By incanus:

There's a memory leak in this line:

config = [[[NSMutableDictionary alloc] initWithDictionary:defaultConfig] retain];

We should probably also make `config` an `NSArray` instead of a mutable one since we're just assigning to it anyway, and not setting it.

And we should probably do a log warning or dialog instead of an `NSAssert` for the user JSON parsing, since this can vary wildly. The `NSAssert` in the case of the bundled `config.defaults.json` is to make sure a build doesn't make it out the door without that file. However, if it happens when parsing a user file, the app could crash in the wild. Better to probably warn or ignore the user file instead.

I'll try to take a crack at this shortly, but just FYI.