RussWhitehead/HPCC-Platform — comment on commit 61458ee1714f8da572c0b8311efccf3e9fb9a68e
File: system/jlib/jlog.cpp line 2697
By ghalliday:

Please can you change this so that it returns the logging message handler (lmh).

The first pull request has created a regression in dfu - in dfuserver.cpp fileMsgHandler is set up, and then accessed from dfurun.cpp as a global variable.

(See https://github.com/hpcc-systems/HPCC-Platform/commit/7439e73725965259aed8e27b195bb0d6f1988bda)

The code is ugly, and shouldn't be done like that, but I suspect we do need access to the message handler to fix it. Can you also add a fix to dfuserver to assign the result to beginLogging to that variable.

We can refactor the code to pass it correctly after that.