ehsan/ohcount — comment on commit e4ae397e592ba2cadfec2820637af6d33ab522bb
File:  line 0
By robinluckey:

Hi ehsan,

Thanks for discovering this bug and providing a fix.

However, I'm going to go with a slightly different fix: if `contents` is NULL, I think it's best to immediately fast-abort the method as soon as we know this. There's no reason to call ohcount_sourcefile_get_contents_size() (and add its result to NULL) or to continue on with any logic once we know that the file is empty.

It's a simple change. The value was in finding the bug -- thank you!

Robin