xwiki/xwiki-platform — comment on commit ea9d06c8f0763539c28592bffc642b10512fcc44
File: xwiki-platform-core/pom.xml line 314
By vmassol:

I think I meant 2 things:

* The diff shows that you changed 3.3 to 3.4 but kept some excludes. Since these excludes were for 3.3 I don't understand why there's also for 3.4. I'm talking about those:

org/xwiki/rest/XWikiAuthentication
org/xwiki/rest/XWikiRestletJaxRsApplication
org/xwiki/rest/XWikiRestletServlet
org/xwiki/rest/XWikiSetupCleanupFilter
org/xwiki/rest/resources/BrowserAuthenticationResource

* I didn't see that you added a new " To be removed when we release 3.3" lower. We have 2 options here:
** keep it like this
** or remove the excludes and modify "xwiki.clirr.previous.version" property to be 3.3-rc-1.

I personally prefer the second option because we should not add new API breakage after RC is released IMO