cwalther/Plasma — comment on commit 3094cbde3c970e52d3e59b9bec4651f2744edb58
File:  line 0
By cwalther:

> That will keep you from hearing a player whom you have ignored.

Hmm? Isn’t that the whole point of ignoring? “I ignore you” = “I don’t hear you”? Either way, this commit has nothing to do with that. It does not change the fact that the ignorer can’t hear the ignoree. Filtering out incoming voice from ignored players happens elsewhere, on the receiving path.

> Voice chat should still be heard by people you have ignored

Exactly. No matter whether I ignore you or not, you should still hear me*. That’s what this commit fixes.

Before, voice chat and text chat were treated differently. This commit is intended to make them treated equally. Independently of what we decide that the correct treatment is, that seems a desirable thing to me.

Don’t let the fact that this code deals with the *listen* list fool you – it doesn’t matter whether the ignored player is on the listen list, as incoming voice from them is filtered out anyway. What I’m looking for is a way of keeping the ignored player on the *talk* list, and since the talk list is synchronized to the listen list, this is the easiest way I found. (That’s my thinking, anyway – critical questioning encouraged.)

\* A worthwhile extension might be to keep the previous behavior (mutual unhearability) in the case that I (the ignorer) have /shun on – you (the ignoree) can’t see me, therefore you shouldn’t hear me either. But that too should apply equally to voice and all variants of text chat.