bwallace/OpenMeta-analyst- — comment on commit da59df5881266f9500a9033af6549d8085802bd6
File:  line 0
By bwallace:

It does return NULL, which results in it using some default for the y-label
when that NULL gets passed along to symbols.

On Wed, Dec 7, 2011 at 11:15 AM, Paul Trow <
reply@reply.github.com
> wrote:

> I've been using pretty.metric.name in all the standard methods for a
> while now, and no problems with spaces in strings. I'd expect it to break
> (return NULL) if the metric was not in the list, but it was breaking for
> OR, which is in the list.
>
> Oh well, as long as it works.
>
>
> -----Original Message-----
> From: byron wallace [mailto:reply@reply.github.com]
> Sent: Wednesday, December 07, 2011 9:13 AM
> To: Trow, Paul
> Subject: Re: [OpenMeta-analyst-] Added y-label to regression plot. This is
> breaking in my buildat metric <- as.character(param$measure) ylabel <-
> pretty.metric.name(metric). This works in R. I pulledbefore trying this.
> (da59df5)
>
> Hmm..I'm having some issues with the latest code. First, it will throw up
> in for one-arm data, because the pretty.metric.name function has no entry
> for "TX Mean". I've fixed this by changing the switch to a named list
> access in said method (this allows for access to strings with spaces;
> switch statements are bizarre in R). So this is resolved. However, the
> y.label is not set as expected, despite the parameter being correct.
> Rather, the plot always displays data.reg$ES, despite the ylabel looking
> ok. This seems to be from the symbols() call in the meta.reg method. Still
> looking into this at current ...
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/bwallace/OpenMeta-analyst-/commit/da59df5881266f9500a9033af6549d8085802bd6#commitcomment-775858
> The information in this e-mail is intended only for the person to whom it
> is addressed. If you believe this e-mail was sent to you in error and the
> e-mail contains patient information, please contact the Tufts Medical
> Center HIPAA Hotline at (617) 636-4422. If the e-mail was sent to you in
> error but does not contain patient information, please contact the sender
> and properly dispose of the e-mail.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/bwallace/OpenMeta-analyst-/commit/da59df5881266f9500a9033af6549d8085802bd6#commitcomment-776267
>

--
byron