jason0/openemr — comment on commit a011b23a44529da14c373789cbc0966e7eaed992
File:  line 0
By yehster:

Your fix makes sense. However, I think the syntax (and the original syntax are confusing, hence the reason this bug managed to get in.)
The intent of the code is to assign $usrvar depending on the state of $show_all.
I think it might be better to write this as
if($show_all=='yes') { $usrvar='_%';) } else { $usrvar=$_SESSION['authUser']; "}

The ternary operator is confusing since we aren't making an assignment. Using if makes it easier to see the purpose of the code IMHO.