lianglee/ban — comment on commit 495ab3c563da626315065c357dd1b80850b61975
File:  line 0
By lianglee:

for elgg_register_admin_menu_item('administer', 'ban',
'administer_utilities'); we need to upload new file in
ban/views/default/admin/administer_utilities/ban.php
i am new on github and can find solution to upload new files in my
fork ban please tell me that how can i add
an/views/default/admin/administer_utilities/ban.php on github my fork
ban ???

On 12/3/11, Liang Arsalan wrote:
> ok i will check it
>
> On 12/3/11, Cash Costello
>
> wrote:
>> Thanks, Liang!
>>
>> Two comments:
>> 1. ban_admin_menu() can be replaced by a call to
>> elgg_register_admin_menu_item(). See the logbrowser plugin for an example
>> of
>> that. If we do that, then we could remove ban_page_handler() and use the
>> default admin page handler just like the logbrowser does.
>>
>> 2. Before php functions we use phpdoc format for comments:
>> ```
>> /**
>> * Comment that describes the function
>> *
>> * @param $name This variable is used for something
>> * @return
>> */
>> ```
>> http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.pkg.html
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/lianglee/ban/commit/495ab3c563da626315065c357dd1b80850b61975#commitcomment-765277
>>
>
>
> --
> _____Best Regards_____
> Buddyexpress
> Administrator
> Liang
>

--
_____Best Regards_____
Buddyexpress
Administrator
Liang