hferentschik/hibernate-search — comment on commit fdda4c2acbdb3c02c1c063d6afe0feb955b301df
File: hibernate-search-orm/src/test/java/org/hibernate/search/test/query/timeout/JPATimeoutTest.java line 51
By Sanne:

sorry my rant was unnecessarily wordy, and as often happens at weekends I haven't used best word selection. I do know you care a lot, and I do too, but we have a problem on the "caring on different priorities".

I understand your POV and see good value in your actions, but I'm just not defending the Eclipse formatting, I'm defending the existing formatting of files which is imho way more important than our opinions, especially it serves to avoid future merge conflicts: it's just not worth it to spend time on resolving conflicts on whitespaces.

And I agree that sometimes it's just needed! I'm not trying to set a new rule, I'm just asking you to avoid this auto-reformat habit of your IDE as - while it's nice looking - in the end it's a waste of time as well. You're still allowed to use it occasionally ;) But at moments like this one, it's just preventing me to perform a quick review as I'm tired already and would otherwise be glad to pull it in. But no worries, I'm not judging the pull request it's more that I'll see for it during the weekend, and I'm sorry for that as we could have avoided it. AFAIR, last time we discussed this it was also a weekend/friday night: so it's not just me being pore picky about pull requests, it's possibly also you being less careful on it :D

>I understand that in some classes formatting has to be taken carefully, for example DocumentBuilder. However, in smaller classes and especically test classes I don't see a reason why we cannot apply the corecct coding style. The changes I made are not too big imo.

You're absolutely right, I'm sorry.