hferentschik/hibernate-search — comment on commit fdda4c2acbdb3c02c1c063d6afe0feb955b301df
File: hibernate-search-orm/src/test/java/org/hibernate/search/test/query/timeout/JPATimeoutTest.java line 51
By hferentschik:

> I do really spend a lot of time to make sure that my pull request don't reformat what is not relevant, it is a bit disappointing to see that my effort is likely
> not appreciated by you as you don't seem to care as much.

I beg to differ. I care a lot about formatting. For me the Hibernate style applies. When I touch a file I generally let the IDE format the file.
I understand that Eclipse might not have exactly the same styles, but that's ok for me. Also about import statements I am not so fuzzy. Personally
I like what Idea does with putting project (Hibernate) imports lasts. Again, I don't mind if Eclipse does it differently.

I am NOT going around formatting files randomly. As said, I format it when I touch it. In some cases I modifiy the file while testing/debugging. In this
cases I normally leave the general code style formatting applied even if I do not change actual code in the end. I try to be careful to distinguish between
formatting/style commits and actual functional changes. In ost cases they will be in different commits.

> This is also going to hurt us when we need to backport fixes; I totally agree we should be strict on good formatting when the initial commits are done for new code,
> or some polishing is acceptable in the short time after that, but I'd really prefer to avoid reformatting older code;

I see this differently. If we have a coding style and want to apply it we should do it (not only for initial commits or new code).
It's like with testing. Committing something without a test, because you will add it later is just not working. In most cases the test will never be written.

I understand that in some classes formatting has to be taken carefully, for example DocumentBuilder. However, in smaller classes and especically test classes I don't see a reason why we cannot apply the corecct coding style. The changes I made are not too big imo.