pascanur/Theano — comment on commit 610b1d16ebdbfd668fa1055bf5aee57e9d250063
File: theano/printing.py line 144
By pascanur:

Done.

So if there is no other op.. do we need to check for this ?

For normal users the eval_points list is constructed by the main Rop
method ( in tensor_grad.py) and it is a new one for each call of the
R_op functions.

What do you think?

On Thu, Dec 1, 2011 at 3:30 PM, Razvan Pascanu wrote:
> Sorry .. I didn't need to do this anywhere else. I just did a grep.
>
> I'll push the changes now ( I had some uncomitted stuff in theano that
> I had to take care of).
>
> On Thu, Dec 1, 2011 at 3:23 PM, goodfeli
>
> wrote:
>> You think you did this in other places in the R_op method or everywhere else? I can write the test, just need to know how broad of a search it should be making.
>>
>> I guess in R_op is usually only called by tensor.Rop maybe the chance for this to cause damage is low. Does the eval_points passed to R_op ever depend on the arguments the user passes to tensor.Rop?
>>
>> I think one use case where this definitely could cause confusion is unit testing, since unit tests often pass the same input several times with small modifications.
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/pascanur/Theano/commit/610b1d16ebdbfd668fa1055bf5aee57e9d250063#commitcomment-762130