jfly/tnoodle — comment on commit c95772df884767c07f5f8545e9e79e9318eb5e0d
File:  line 0
By jfly:

Overall, this looks like a great start. I love the ui. Thanks for helping out!

I didn't get through the whole review, but here are some things I did notice.

Some high level thoughts:
- The "Add" button doesn't seem to add any value. Just nuke it & reacte to the rounds & scrambles spinners.
- Scrolling through the event selector doesn't seem to select an event until I actually click on it with the mouse.
- Clicking "Get Scrambles" with no scrambles isn't pretty.
- Is the Get Scrambles button strictly necessary? What if you just make it a status (like, "Generating scrambles" or "Scrambles all generated"), and simply query for more scrambles every time the page changes? If the page changes during while a request is pending, just kill the old request.
- Adding too many rounds to an event overflows at 4. Maybe you could add scrollbars? Or maybe you should restrict it to 4 because that's as big as competitions can get?
- The groups spinner and the copies spinner are on different lines in my browser. The wrapping doesn't look like it should be necessary. I can send a screenshot if you like.
- How about created groups by letter, rather than by number? We've already got numbers for rounds.

Stuff you already know, but I'm just going to keep saying it so we have a list somewhere.
- URL URL URL
- Editing events after they've been added. This might require adding a little hierarchy to the Event table at the bottom. I'm imagining it would be cool if you could just click on a "row" (more like a set of rows) after they've been added, and be able to edit it in the gui you were just using to create it. Does that make any sense?
- Reordering. I know I've said several times that this would be cool, but is it even a good idea? It seems to me like you have a better idea of what order the scrambles should be printed in than the user does. I totally trust you if you decide reordering is a useless feature. There isn't even the concept of ordering inside of a zip file...