henryyan/jqGrid — comment on commit a7de5b70ba71fdf342e7af8969416870ce18d873
File:  line 0
By OlegKi:

It's good suggestion in my opinion! I hope that Tony will include `op` and `text` as properties of `groupOps`.

I would only modify the code so that one tests whether `op` and `text` property are defined or not. If the properties are undefined one should use `that.p.groupOps[i]` instead of both `that.p.groupOps[i].op` and `that.p.groupOps[i].text`. Such changes can fix compatibility problems with old unmodified language files.

Another remark: `$.extend(true, arg, $.jgrid.search)` is not really required because it will be used in `searchGrid` in [the line](https://github.com/tonytomov/jqGrid/blob/v4.2.0/js/grid.formedit.js#L59). You will not find `jqFilter` method in [the documentation](http://www.trirand.com/jqgridwiki/doku.php?id=wiki:jqgriddocs#searching) of jqGrid, only [searchGrid](http://www.trirand.com/jqgridwiki/doku.php?id=wiki:singe_searching#calling_conventions). The `$.jgrid.search` are documented [here](http://www.trirand.com/jqgridwiki/doku.php?id=wiki:singe_searching#options) as the options of `searchGrid` and not `jqFilter`.

Best regards
Oleg