charlotte-ruby/impressionist — comment on commit 345f917d4af060a55a38101a539bf19d7422b42f
File: lib/generators/impressionist/templates/create_impressions_table.rb line 12
By johnmcaliley:

I should have named it session_id

On Nov 30, 2011, at 12:49 PM, Cory Schires wrote:

> Ah. Looks like I was confused. In that case, I agree.
>
> Cory
>
>
> On Wednesday, November 30, 2011 at 11:07 AM, John McAliley wrote:
>
>> It should be just the id of the rails session, which is 32 hex characters.
>> It does not store all the information in the browser session
>>
>> On Wed, Nov 30, 2011 at 11:45 AM, Cory Schires <
>> reply@reply.github.com (mailto:reply@reply.github.com)
>>> wrote:
>>
>>
>>> Yeah. I saw that as well.
>>>
>>> Concerning the session hash. Before making the change, I looked thru my
>>> logs found some session hashes that were close to the limit (e.g. csrf
>>> token, warden auth stuff, and maybe one other thing and your getting close
>>> to the limit). That said, I didn't actually find any that were over. But I
>>> figured that better safe than sorry, not thinking that changing to text
>>> would cause any issues.
>>>
>>> Point being, it's probably safe to go back to string. But I think best
>>> practice would be to code it defensively and keep that field as text if
>>> possible -- especially since some people might be (stupidly) cramming a
>>> bunch of stuff in their session. But, of course, it's up to you.
>>>
>>> Best,
>>> Cory
>>>
>>> PS: It looks like neither `message` nor `referrer` are indexed so we're
>>> probably good with those.
>>>
>>>
>>>
>>> On Wednesday, November 30, 2011 at 10:06 AM, John McAliley wrote:
>>>
>>>> There was an issue submitted earlier this morning where the index on the
>>> text field was failing for mysql2 gem. I don't think this will ever need to
>>> be longer than string, so I am changing it back and releasing a new
>>> version. Let me know if you see any reason to keep this as a text
>>>>
>>>> ---
>>>> Reply to this email directly or view it on GitHub:
>>>>
>>>
>>> https://github.com/charlotte-ruby/impressionist/commit/345f917d4af060a55a38101a539bf19d7422b42f#commitcomment-758101
>>>>
>>>
>>>
>>> ---
>>> Reply to this email directly or view it on GitHub:
>>>
>>> https://github.com/charlotte-ruby/impressionist/commit/345f917d4af060a55a38101a539bf19d7422b42f#commitcomment-758246
>>
>>
>>
>> --
>> John McAliley
>> CouponShack.com (http://CouponShack.com)
>> office: 803.619.5054
>> cell: 803.487.4359
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/charlotte-ruby/impressionist/commit/345f917d4af060a55a38101a539bf19d7422b42f#commitcomment-758341
>>
>>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/charlotte-ruby/impressionist/commit/345f917d4af060a55a38101a539bf19d7422b42f#commitcomment-758500