dabloem/yubico-java-client — comment on commit ea24cea0af32a8221a85135a53bb12a5947b4452
File:  line 0
By fredrikt:

Thank you for your interest in the Yubico Java client.

I'm unhappy to have to bring this issue up, but a lot of statements in your patch very much looks like they are copied straight from YubikeyLoginModule.java, but the Copyright notice at the top of the file has been removed. If your work is derived from ours, you have to keep the copyright header. You may add your own copyright covering the parts you've written (and you have to clearly identify those).

You hard code client id (4711) in your code, which indicates it is not feature complete.

I don't really follow the differences between GlassFish's realm thingy, and the YubikeyToUserMap scheme. Couldn't the Realm functionality be implemented as an implementation of YubikeyToUserMap?

Thanks.

/Fredrik