pkp/omp — comment on commit 59195234935531f4e28003ea1d33edbd94a9f7b3
File: classes/submission/seriesEditor/SeriesEditorSubmissionDAO.inc.php line 396
By beghelli:

Alec, I think that it was LEFT JOIN because we just need to check if there is no review assignment to the user. The way you did it's not working because it JOIN the review assignments table, and it can't find any record there, because the user is not assigned yet as a reviewer. So none is returned, the inverse of the original code. Also, I think that the clause WHERE r.submission_id IS NULL is to make sure that we will get a user with no review assignment for that monograph, stage and round. If you agree, I can revert this. I just want to ask first because I did not understood why you changed the original code. :)