aptana/studio3 — comment on commit 5d79dad8ac665b8dd584abb9e8eb537eef7a21c3
File: plugins/com.aptana.index.core/src/com/aptana/index/core/build/BuildContext.java line 89
By thelonious:

The handling of parseState in this method is a bit confusing to me. We save a reference to the passed in parse state only when our current cache is null? I would think you'd want to cache the passed in parse state every time unless, as in your TODO, we have a way to test for equality. You reference fParseState throughout this method but then pass the parseState argument here. It seems like fParseState should be used, possibly requiring an assignment as just mentioned.