rgarcia/instacss — comment on commit 97a382c275969ff682ebb5041b77d1ff24e2fefd
File: static/js/views/searchheader.js line 68
By vecter:

lol yeah i agree w/most of these points.

i actually had them all in the same list at the beginning, but it was hard
to tell where the CSS ended and where the HTML began. I thought of two ways
to fix this, one way which you see now. the other way is to have some text
separate the two, but given the way we build the

, it's actually a
little harder to do in practice.

speedwise, search is about the same (at least no noticeable difference). i
even added some optimizations for when the query box is empty.

fastest way to hide/show:
http://www.learningjquery.com/2010/05/now-you-see-me-showhide-performance(so
i changed everything to .css{'display': 'none'{

i think the best way is to have them in separate databases as you said. it
just turned out to be much less code to do it this way (the schema for the
backend db is identical). obviously this won't scale as we add other
languages, so i would like to refactor it out like you said.

On Sat, Nov 26, 2011 at 9:36 PM, Rafael <
reply@reply.github.com
> wrote:

> speed fail
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/rgarcia/instacss/commit/97a382c275969ff682ebb5041b77d1ff24e2fefd#commitcomment-748278
>

--
Kevin