epema/ass2 — comment on commit db573f53dee054be248e38b0a6ce3bb671669a9f
File:  line 0
By alanhsu:

yeah, before there wasnt the calibration model. Don't worry, i'll take
that out.

On Fri, Nov 25, 2011 at 10:27 PM, kokShay

wrote:
> Do you really want setLeftScale(), setRightScale() and setUnit() to be in main view?
> I think this methods don't set any attributes of View.java... and they are not related to View.java..
> Actually, I don't know what they do, but it seems like mixing concerns to me... You are implementing Calibration, so put all related stuff into view or model of calibration...
> Same idea about controller, don't put your computation to controller. Take it into your model or view(not main model or view).
>
> Mixing concerns!
>
> I mean, this makes hard for me to understand main MVC, which we all should understand. As for your own part, you can do there(in calibration model and calibration view) whatever you want. As you can see, I don't have any stuff from my part in main view and in controller, so that nobody gets confused.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/epema/ass2/commit/db573f53dee054be248e38b0a6ce3bb671669a9f#commitcomment-747231
>

--
Alan Hsu
York University
Faculty of Science and Engineering, Computer Science