jwise/rust — comment on commit 5fdc90a192ab82d2508607f3266eafde5440ba4d
File: src/lib/c_vec.rs line 20
By brson:

None of these functions are marked unsafe, i.e. 'unsafe fn', they just call unsafe functions. That seems to contradict the language here.

Arguably this module is intended to make using native buffers 'safe', for some value of 'safe', but it seems like something here should be marked unsafe. In the language pointer dereferencing is unsafe, so maybe get/set should be unsafe. Maybe we want to consider accessing a c_vec safe, then create should probably be unsafe.