smichr/sympy — comment on commit 29036dd7008b48969dd2b729fcd14bd10296ace5
File: sympy/combinatorics/subsets.py line 371
By saptman:

You could write a doctest that shows the case when you croak.

I like this routine, not only is it quite clever, it also does takes corner cases into account as well. However, I think trying to create a subset whose elements are not in its superset will raise an error in the constructor itself.

+1 from me.

For some strange reason, I did not get a notification for this pull request.