schakrava/zfs — comment on commit 098815f0058c7fcd180d7936025b375a3a36f6dc
File:  line 0
By behlendorf:

Thanks for the cleanup this looks much better. I've merged your patch in to master with just a few minor tweaks listed below. Nothing critical just mostly cosmetic.

* Shortened the first line of the commit message (it's good to keep it short for `git log`). For example:

$ git log -3 --pretty=o
926fba7f0e29267b9e7369f003df4078c5377fc7 Allow leading digits in userquota/group
ca5fd24984624146ebd1460d7554f42b0572e45f Limit maximum ashift value to 12
09559cdd150fa0b610dd4f816292fd90f50fd0cb Fix depmod warning

* Added `Closes #428` Github magic syntax to the commit message to link the patch back to the original issue.

* Tweaked the isuser/isgroup formatting since in this case it can all fit on one line.

* Restricted the scope of the `end` and `numericsid` variables to avoid the following warnings.

../../lib/libzfs/libzfs_dataset.c: In function ‘userquota_propname_decode’:
../../lib/libzfs/libzfs_dataset.c:2261: warning: unused variable ‘numericsid’
../../lib/libzfs/libzfs_dataset.c:2260: warning: unused variable ‘end’

As for your broader question about HAVE\_IDMAP, let me explain. Several of the HAVE\_* macros you see in the zfs code were added by me when originally porting the code to Linux. They are never defined and were added to disable certain functionality until a Linux equivalent could be found/implemented. In this case until we come up with a clean way to support the Solaris idmap functionality under Linux.

Frankly I haven't seriously investigated adding support for idmap since Linux doesn't have an in kernel Samba server like Solaris. We rely on the usual Linux mechanisms for this sort of thing, but perhaps we can do better. The samba documentation would probably be a good place to start.

http://www.samba.org/samba/docs/man/Samba-HOWTO-Collection/idmapper.html