zkhalapyan/whoop-txt — comment on commit cddf722089803310adc5049bcaf94b392569c560
File: srs/mobile/share.html line 102
By wnorris:

Personally I think that we should not ignore geo-location if errors happen.
The app depends almost entirely on location and to ignore it would add lots
of complications later. I think the correct error would be to notify them
and not send the message.

As for the cryptic nature, it was a temporary message since it was a first
attempt at that code and the error message was meant for debugging. I think
code reviews are great, but maybe once people are done developing the part
being reviewed. The spot you are reviewing is not done in development yet.

Best,
Wade

On Fri, Nov 18, 2011 at 4:35 PM, Zorayr Khalapyan <
reply@reply.github.com
> wrote:

> Alerting the user with some cryptic message is probably not the best way
> to handle errors. Could you just ignore geolocation in case of some errors
> do happen?
>
> I am testing out git-based code review - how do you like it?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/zkhalapyan/whoop-txt/commit/cddf722089803310adc5049bcaf94b392569c560#commitcomment-731936
>