peterjc/samtools — comment on commit f7d89692b08081802bc5d01d266d212a2875fc5a
File:  line 0
By jmarshall:

Do we really want to have this "\037\213\010\4\0[...]" magic constant proliferating through this code?

Instead of your patch, it would be clearer just to add fp->compress_level = 0 in front of bgzf_close()'s deflate_block() invocation, or (better) to add a compress_level parameter to deflate_block(), to be set appropriately on the two invocations of deflate_block().

(Otherwise, for pity's sake just lift bgzf_check_EOF()'s existing magic constant to file scope rather than duplicating it!)