vingtetun/webcontacts — comment on commit 36be665c754cb8f79ac9ffd2f4de827c2a3cc5d5
File:  line 0
By philikon:

Thanks, Vivien. A couple of points on the coding style changes:

- The Mozilla coding style prefers double quotes over single quotes for string literals (https://developer.mozilla.org/En/Mozilla_Coding_Style_Guide#Literals)
- I personally prefer explicit braces around all blocks, even if they're just one line. Means less churn when you refactor/extend the code.
- The space between a 'for each' and the open paren should still be preserved https://developer.mozilla.org/En/Mozilla_Coding_Style_Guide#Control_structures
- I agree that binding callback methods to 'this' and then using 'this' everywhere instead of 'AB' is probably better. In that case, we might as well do it everywhere rather than the ubiquitous 'let self = this', right?

Question:

- You removed the 'return false' for the various button onclick handlers... I found that this means the button will submit the

. Unless I'm missing something, add/edit forms will not work anymore.

The other changes look good. I would merge them if you had done them in individual commits, separate from the coding style changes :/