pkp/pkp-lib — comment on commit 65a9054d3ea639dda140e580242b120edb03ec4a
File: classes/controllers/grid/citation/PKPCitationGridRow.inc.php line 120
By asmecher:

I understand the distinction between a fatal error and an assertion. Practically speaking, a production system should have assertions disabled and a development system should have them enabled. I would rather err on the side of caution by using fatalError for something that might have security implications for production systems. For development systems, the effect is the same. I've changed out a number of assertions for fatalErrors where I thought security might be at play. There is no risk if it turns out not to be a security problem. Sorry, I'm not going to search my commits for examples; I just don't see any practical benefits in reverting this.