erikrose/oedipus — comment on commit 85320f7d03f52935d4272682bcc6e8e5c34c6720
File:  line 0
By willkg:

I think this code is fine, but there's a bug in the clone method: it should be copying the highlight_options dict from the previous S rather than using the same dict.

e.g. on or around line 94 in __init__.py, it should be:

new._highlight_options = dict(self._highlight_options)

That assumes we want options to accrete--that's what I was coding for. I'm pretty sure that's what we want, but it's not something we should spend much time discussing since we don't use it in kitsune.