alphagov/whitehall — comment on commit d66d9fdd898b5b9c7644b1a6346304489a32e8e2
File: app/models/role_appointment.rb line 43
By floehopper:

Although this is now (since this commit) better behaviour, I'm concerned that it assumes that a new appointment is added on the day that the new appointment starts. It might be a bit of an edge case, but if a user adds a new appointment without ending the previous appointment, the end date will be set to the current date, which might be a bit confusing to the user. Anyway, I don't think it's a big deal, but at least worth keeping in mind.