danmar/cppcheck — comment on commit 2aceb623ae53d1f3a2dfa9aa118f498fcf6e6ca0
File: lib/token.cpp line 226
By reif:

Silently ignoring and even hiding bad things is the cppcheck way of doing things. Daniel should have the final say on this issue. I just pointed out that your new code will crash given the right input. Functions of a core class shouldn't crash when avoidable. There is no guarantee how core class functions will be used.