agscala/Dice-Game — comment on commit 6a7c6545f374d44c89e8b154d5177e63422fcc02
File:  line 0
By agscala:

Indentation is different from function to function.

You didn't actually pull UI out of the class. The Dice class is simply supposed to maintain state and provide interfaces to modify it and return information about what the state currently. The UI is supposed to handle flow and will do things like "If this div is clicked, update the state appropriately." This way if we ever need to make changes to the UI, we don't ever need to touch the Dice class, it should already have all of the functionality it needs without being tied to UI at all.

If you can, write a javascript function that tests the dice class and makes sure it works correctly by setting/retrieving information from it. Make sure you can't do goofy things like save 3 pairs somehow or get any strange data into the class.