geany/geany — comment on commit efcce8808e92ba56684605790959cb014a11c9c8
File:  line 0
By elextr:

On 5 November 2011 13:59, Matthew Brush

wrote:
> This could also be more generic:
> ```
> Prefer not using macros that affect code readability unless critical. For example, don't use G_LIKELY unless in a tight loop, or other performance-sensitive operation.
> ```
> I'm looking at you `NZV`, `setptr` and most recently `NVL` :)

Actually these macros are dangerous because they hide the fact that
sometimes their arguments are not evaluated, sometimes evaluated once
and sometimes twice.

This breaks if any argument has side effects. They should be inline
functions on systems that support it and real functions if not.

>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/geany/geany/commit/efcce8808e92ba56684605790959cb014a11c9c8#commitcomment-697092
>