TrinityCore/TrinityCore — comment on commit b268b51d0ef991b73c140a680aebca582fc10e00
File:  line 0
By Ric101:

Excuse me, but this method includes buffs and skills that increase Block Value

A Warrior using Shield Block while hardcapped should still get double increase out of the ability, same probably happens with Glyphs/other buffs that do similar effects

"[quote name='Scorpz' timestamp='1320339512' post='65985']
For all the guys thinking of being a PvP Prot here is the damage that [url="http://www.wowhead.com/?spell=47488"]Shield Slam[/url] will deal for Warriors who have the following talents.[list][*][url="http://www.wowhead.com/?spell=29599"]Shield Mastery[/url], [url="http://www.wowhead.com/?spell=12958"]Gag Order[/url], [url="http://www.wowhead.com/?spell=16542"]One-Handed Weapon Spec[/url], and [url="http://www.wowhead.com/?spell=29594"]Imp Defensive Stance[/url].[/list]And one factor that is not a talent that will come in is [url="http://www.wowhead.com/?spell=71"]Defensive Stance[/url]. While the current damage reduction is 10% in the upcoming 3.1 patch it will be reduced to 5% only.

[url="http://www.wowhead.com/?spell=2565"]Shield Block[/url] Is something that can boost the damage of this ability greatly. You can look at this ability as [i]"Make my next 2-3[/i] ( Depending if [url="http://www.wowhead.com/?spell=46953"]Sword and Board[/url] procs) [i]Shield Slams deal massive damage"[/i]
Another thing to note is that [url="http://www.wowhead.com/?spell=47296"]Critical Block[/url] will not help this ability. This talent does not give a buff of any type, it simply gives your blocks a chance to "Crit" and block double the amount for that single attack only.
Another thing that will help greatly is [url="http://www.wowhead.com/?item=43425"]Glyph of Blocking[/url].

NOTE: I will not link these again and will do the rest of the comment using the abbrevations

[i]SS= Shield Slam, IDS = Improved Defence Stance, SM = Shield Mastery, GO = Gag Order, O-H WS = One-handed Weapon Spec[/i] (O instead of 1 to avoid too much numbers) [i]GOB = Glyph of Blocking, DS = Defensive Stance, and SB = Shield Block[/i]
and etc. I will also be using a SBV of 1000. About average for a person with some tanking gear. If that isn't normal, too bad, I like the nice, round number.[list][*]Normal Damage. (No chance for first SS to proc the Glyph or Imp Def Stance to be active.)
(1000 [Average SS base Damage] + [1000 SBV x 1.3 SM = 1300]) x 0.9 DS x 1.1 GO x 1.1 O-H WS = roughly 2500 Damage[/list][list][*]Damage with Improved Defensive Stance procced
(1000 SS + [1000 SBV x 1.3 SM = 1300]) x 0.9 DS x 1.1 GO x 1.1 O-H WS x 1.1 IDS = roughly 2750 Damage[/list][list][*]Damage with GOB active
(1000 SS + [1000 SBV x 1.1 GOB x 1.3 SM = 1430]) x 0.9 DS x 1.1 GO x 1.1 O-H WS = roughly 2650[/list][list][*]Damage with SB active
(1000 SS + [1000 SBV x 1.3 SM x 2 SB = 2600]) x 0.9 DS x 1.1 GO x 1.1 O-H WS = roughly 3900 Damage[/list]You can roll all these factors together to get this Grand Daddy formula[list][*]Damage with SB, GOB, and IDS procced
(1000 SS + [1000 SBV x 1.1 GOB x 1.3 SM x 2 SB = 2860]) x 0.9 DS x 1.1 GO x 1.1 O-H WS x 1.1 IDS = roughly 4600 Damage[/list]But this base damage is all on normal hits, what matters is the Shield Slam Crits that will come hard and often thanks to things like [url="http://www.wowhead.com/?spell=47296"]Critical Block's SS Modifier[/url][list][*]The Grand-Daddy Crit Formula with the [url="http://www.wowhead.com/?spell=16494"]Impale[/url] talent
4600 x 2.2 = 10120 damage[/list]And this is a basic number, there is many who have a Block Values of 1400+ and achieve crits of 13000 and higher.

From these reports, I have crunched the numbers and found that either WoW SS calculates the additives to SBV twice
(Once for base SBV and again for SS damage) or WoW stats do not count additives to SBV on the character window. But my guess is the first one. And according to how SS is phrased, seems the best choice and makes some sense.

But if this is true, then the formulas above must be redone with all additives done to the base SBV once then the higher number is to be put back in to be affected by the same modifiers again.
This theory must be tested by someone with a bit more time on their hands than me to be confirmed, but given this following formula, it seems to add up.[list][*]SBV Base = 1400 x 1.1 GOB x 1.3 SM = 2002
(1000 SS + [2002 SBV x 1.1 GOB x 1.3 SM x 2 SB = 5725]) x 0.9 DS x 1.1 GO x 1.1 O-H WS x 1.1 IDS x 2.2 Crit = 17710 roughly[/list]The only issue I got with this formula is that SB isn't calculated twice, two explanations to this thing.
1: I am missing something in the original formula that adds to the damage.
2: Blizz knows this and the Devs only made it to be added in once.

If the latter is true, then we can be looking at a nice boost coming the next patch.[list][*](1000 SS + [2002 SBV x 1.1 GOB x 1.3 SM x 2 SB = 5725]) x 0.95 DS x 1.1 GO x 1.1 O-H WS x 1.1 IDS x 2.2 Crit = 18705 roughly[/list]
"