bigfix/sequel — comment on commit 61abc69b91e1b2e32a7c5087e79c75b044c81e9e
File:  line 0
By jeremyevans:

I don't think this is correct, at least not with the current Sequel code. The fractional seconds probably get ignored. You'll have to modify Sequel::Timezones#convert_input_timestamp to handle an array with 7 elements. I'm not sure if there are specs that test for fractional seconds, but if not, they should probably be added. Have you run this through the integration specs?

Also, you can't depend on Rational being loaded in the specs, as Sequel never loads rational directly. You have to guard it with defined?(Rational), and use a float based calculation if it is not defined.

Additionally, if you are going to optimize the Timestamp case, we should probably also optimize the date and time cases as well. Those should be simpler, with Time just using Sequel::SQLTime.create(hour, minute, second, usec), and Date just doing Date.new(year, month, day).