markfisher/spring-integration — comment on commit 8dcef74ded9a5a434a77e73c5f488b8ae051ffda
File:  line 0
By olegz:

Well, there is actually a bigger problem and you can see it in the following 4 methods where it is called:

- public void completeGroup(Object groupId)
- public void setLastReleasedSequenceNumberForGroup(Object groupId, int sequenceNumber)
- public MessageGroup removeMessageFromGroup(Object key, Message messageToRemove)
- public MessageGroup addMessageToGroup(Object groupId, Message message)

The only method where its current or your refined implementation makes sense is the last one. For other 3 it is actually a bug IMHO since the other 3 methods should *only* work if MessageGroup exists and if for some reason MG does not exists it should result in error.

There is also a another and more serious problem lurking there and I am actually discussing it with Juergen, so I'll follow up shortly