technomancy/wabbitmq — comment on commit 1a64a5c4b79c632e08b93e69e4af4f1dfe003fcf
File:  line 0
By mefesto:

Looks good to me but would you mind having env-config ignorant of connection-defaults? Something like below:

(defn- env-config []
(when (System/getenv "RABBITMQ_URL")
uri-config))

(defn- connection-factory [config]
(let [cfg (merge connection-defaults (env-config) config)]
...))

Then, for me at least, it's easier to see how a connection factory is assembled simply by looking at that function and reading the call to merge.