nouiz/Theano — comment on commit 93a4f8e959417132a3acb2e1103b06614913c65e
File: theano/tensor/opt.py line 935
By nouiz:

if both new_r and r have shape information, update_shape give priority to the second one. As we change the input in the graph, I think we should give priority to the new one.

I don't see what doing both will bring? Can you explain?

Ideally we should do something more cleaver, like making sure there is nothing that depend on the old one if the old one is removed from the graph. This is to ensure that we don't keep something in the shape_of that is usefull only for the shape.

It think this pull request is urgent. If this si the only objection that you have to this pull request, can you just tell so. I will rever that 1 line change and we will move this discussion elsewhere to don't delay the crash fix.