sunlightlabs/brisket — comment on commit 74d8c2c79c4d3b56ba6b8734cc2204a8f78e1e74
File:  line 0
By apendleton:

I meant to comment on this over the weekend, but forgot. In any event, this strikes me as a poor idea. I was getting crashes on my local copy of brisket over the weekend due to missing API methods and couldn't figure out why, since I had run a pip update. It took about ten minutes of wasted time re-running pip upgrade to discover that some of brisket's dependencies had been removed from requirements.txt. Removing the requirement means there's no obvious way to update this package to the newest version, makes deployment harder, and means there's no longer a canonical list anywhere of what packages we (or anyone else) needs to make brisket work. If our virtualenv setup is broken in production such that pip upgrade doesn't work, we should fix our virtualenv setup. If our packages aren't nicely pip-installable, we should fix our packages. But requirements.txt should reflect the packages necessary for brisket to run, not an arbitrary subset of them, especially if it's not documented anywhere that there are some missing.