cjeanneret/puppet-tomcat — comment on commit 76b833cbde4773ef1baf2d4450167c8651e6ffa7
File:  line 0
By mfournier:

I would find "cd $CATALINA_BASE" better: maybe less readable in the ERB template, but would make more sense in the shell-script output on tomcat nodes.

Else +1 (although setenv.sh and setenv-local.sh should better refer to $CATALINA_HOME and $CATALINA_BASE, instead of using relative paths)