xarion/vert.x — comment on commit 253edb1182e594ccddce815004c071d305183f0e
File:  line 0
By purplefox:

Erdi,

I had a quick look at your commit.

Is it necessary to do the check for sending the 100-Continue twice? Once in HttpServer and again in HttpServerResponse.writeHead? The one in HttpServerResponse seems redundant to me.

Also there's a problem with the responded flag in ServerConnection, it seems redundant, since there's already a pendingResponse flag you could use. Also the life cycle seems to be incorrect - you're setting it to true when write() is called on the ServerConnection, which does not signify a response being complete.