BRAINSia/BRAINSStandAlone — comment on commit 8778dc548e26205d003ffd151869f8236062d367
File: BRAINSDemonWarp/debugImage.h.in line 8
By Chaircrusher:

I will try to respond to your comments with a single pull request in the
next couple of days. They're all good suggestions.

On 10/28/11 3:51 PM, "Jean-Christophe Fillion-Robin"

wrote:

>Thanks :) Which commit is associated to your fix ?
>
>Ideally, you could follow a topic / pull request workflow.
>
>Jc
>
>On Fri, Oct 28, 2011 at 4:44 PM, Kent Williams <
>reply@reply.github.com>wrote:
>
>> I pushed the fix for the compile error with that flag turned off.
>>
>> I'm currently trying to do further work on making BRAINSDemonWarp easier
>> to debug with respect to the problems with ITKV4. From Now on I'm going
>>to
>> move to a fork in Github.
>>
>>
>> --
>> Kent Williams norman-k-williams@uiowa.edu
>>
>>
>>
>>
>>
>>
>> On 10/28/11 3:41 PM, "Jean-Christophe Fillion-Robin"
>>
>> wrote:
>>
>> >I would also suggest to avoid using macro, you could instead define an
>> >object, and or function that could be used instead.
>> >
>> >The macro would be use just as a wrapper around the function call so
>>that
>> >__LINE and __FILE__ are passed automatically.
>> >
>> >For example, you could inspire from what's done here:
>> >
>>
>>https://github.com/benjaminlong/CTK/blob/QtTesting-FirstPass/Libs/QtTesti
>>n
>> >g/ctkEventTranslatorPlayerWidget.h#L36
>> >
>> >--
>> >Reply to this email directly or view it on GitHub:
>> >
>>
>>https://github.com/BRAINSia/BRAINSStandAlone/commit/8778dc548e26205d003ff
>>d
>> >151869f8236062d367#commitcomment-682139
>>
>>
>>
>> ________________________________
>> Notice: This UI Health Care e-mail (including attachments) is covered by
>> the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
>> confidential and may be legally privileged. If you are not the intended
>> recipient, you are hereby notified that any retention, dissemination,
>> distribution, or copying of this communication is strictly prohibited.
>> Please reply to the sender that you have received the message in error,
>> then delete it. Thank you.
>> ________________________________
>>
>> --
>> Reply to this email directly or view it on GitHub:
>>
>>
>>https://github.com/BRAINSia/BRAINSStandAlone/commit/8778dc548e26205d003ff
>>d151869f8236062d367#commitcomment-682145
>>
>
>
>
>--
>+1 919 869 8849
>
>--
>Reply to this email directly or view it on GitHub:
>https://github.com/BRAINSia/BRAINSStandAlone/commit/8778dc548e26205d003ffd
>151869f8236062d367#commitcomment-682164

________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.
________________________________