mozilla/appsync — comment on commit dfb9f783c240ccf693554496c9e834651644326f
File: appsync/views.py line 38
By ianb:

I think we want: if res is not None and res.group(1) != audience

Also, for the SQL backend, each application should be stored only once. So
we have to do a SELECT/INSERT/UPDATE, or a REPLACE (which MySQL supports,
maybe SQLite does not?)

Technically we could have extra apps stored, and maybe clean them up
offline, though I doubt that'd save any effort ultimately... but at least as
a Sauropod requirement we don't strictly need to handle it. But... it
certainly seems cleaner when we do ;)

On Wed, Oct 26, 2011 at 5:08 AM, Tarek Ziade <
reply@reply.github.com>wrote:

> This breaks the code and the tests, we want one of these:
>
> - if not res or res.group(1)
> - if res is None or res.group(1)
>
> Fixing..
>
> --
> Reply to this email directly or view it on GitHub:
>
> https://github.com/mozilla/appsync/commit/dfb9f783c240ccf693554496c9e834651644326f#commitcomment-675772
>