nperrier/sockso — comment on commit 94e43113f38dad3bc99e9e5515d8d3bdd645b858
File:  line 0
By rodnaph:

Looks good, my only suggestions are...

1) i try to avoid creating "utlity" classes with static methods. instead it might be better to create a CoverArtImage class, and then have the current static methods as instance methods on those particular objects.

2) the DBCollectionManager class is currently a bit of a monster, so i'm reluctant to add more stuff to it when ideally I want to move/remove a lot of what is already there. so instead of adding a method to this class, maybe it would be cleaner to add the functionality by composition. If you create a CoverArtIndexer class than is a dependency of the DBCollectionManager, and the collection manager can just use it then.

What do you think?