willkg/kitsune — comment on commit dd4355227b3cb6c883768379b991c099220e1175
File: apps/search/tests/test_search.py line 129
By erikrose:

You may have a point there. Though using the wiki_search object itself shouldn't cause any noticeable problems (since any method later called on wiki_search returns a clone that doesn't carry its parent's `_results_cache`), it would hold onto any results indefinitely. I'm more and more looking forward to our ``def gimme_a_default_wiki_search()`` that we'll need for ES/oedipus waffling, and I think we should consider keeping it even when we're not waffling anymore.