oemr501c3/openemr — comment on commit 347466177bf96422154fe0971efdadc361dd87ec
File:  line 0
By tmccormi:

You did not screw up. You posted you own version of the branch, that's
fine, better in fact.

Tony

On Mon, Oct 24, 2011 at 10:42 PM, Art Eaton <
reply@reply.github.com>wrote:

> OK, screwed up and started a branch "5010".
> It should be synced up with the dev tip. Some bits might not LOOK like
> they are, but I am pretty sure it is where I intended it (not that it means
> much).
>
> I'll get the sql upgrade file merged into the 4.2 upgrade (or whatever it
> is
> the current).
> ----- Original Message -----
> From: "Rod Roark"
>
> To: "Art Eaton"
> Sent: Monday, October 24, 2011 4:35 PM
> Subject: [SPAM] Re: [openemr] 5010 837 Preliminary, OEMR (3474661)
>
>
> > Hi Art,
> >
> > I guess I'll mostly use it to check for things I may be missing. But if
> > you can provide a diff against current dev code that will help a lot.
> >
> > Thanks!
> >
> > Rod
> >
> > On 10/24/2011 01:22 PM, Art Eaton wrote:
> >> Sorry guys.
> >>
> >> Quoting Tony: "Very Preliminary".
> >>
> >> I went through the 837 gen file knowing that I can't test it myself
> >> without having the extra configurations to the x12 partners, so I had to
> >> throw in the extra class and templates for reference. It's something
> you
> >> might consider including in a new version anyway, seeing as it's
> required
> >> for at least two fairly large partners and doesn't get in the way
> >> otherwise.
> >>
> >> I also didn't really intend to review the code this way, it was more
> >> of a "go through the value changes" reference and identify the extent of
> >> the changes necessary. The file is mostly to identify the areas of
> >> change that are real problems, or need a more comprehensive fix than
> just
> >> altering the generator.
> >>
> >> I used a lot of comment crap to make it easy for me to spot the areas
> >> that I KNEW might have serious issues. I wanted (at 3:30 AM) to be able
> >> to spot them quickly when I got back from the salvage operation. I'll
> >> gladly diff this against a 4.1 stable release, or a new dev release...if
> >> I can figure out what you guys need, and get rid of the excess comment
> >> crap when the few show-stopping "what the heck do we do about this"
> parts
> >> get some sort of resolution or feedback.
> >
> > --
> > Reply to this email directly or view it on GitHub:
> >
> https://github.com/oemr501c3/openemr/commit/347466177bf96422154fe0971efdadc361dd87ec#commitcomment-671463
> >
>
> --
> Reply to this email directly or view it on GitHub:
>
> https://github.com/oemr501c3/openemr/commit/347466177bf96422154fe0971efdadc361dd87ec#commitcomment-672337
>
>