TireSwingSoftware/openassign-server — comment on commit cef34bf2f97a24b27f9d31963f675a261ed7d6f1
File: pr_services/pr_tests.py line 3262
By jc0n:

Right. I also noticed those tests use keywords as identifiers which is not a
very good idea. I'll rewrite those to test the same cases on a model from
pr_services.

- John

On Sat, Oct 22, 2011 at 2:21 PM, Michael Hrivnak <
reply@reply.github.com>wrote:

> Well, this is testing a feature of pr_services (UtilsManager), so that
> feature should be tested by pr_services tests. Just as pr_services
> tests don't make any direct effort to verify that django functions
> properly, vod_aws doesn't need to verify that pr_services functions
> properly. In sum, we should test UtilsManager in the app where it's
> written, which is pr_services.
>
> On Sat, Oct 22, 2011 at 2:10 PM, John O'Connor
>
> wrote:
> > OK. I thought about doing that but wanted to preserve the test cases as
> > well. Maybe we can move them to the suite for vod_aws?
> >
> > - John
> >
> >
> > On Sat, Oct 22, 2011 at 1:58 PM, Michael Hrivnak <
> > reply@reply.github.com>wrote:
> >
> >> The functionality we are testing here has nothing to do with the VOD
> app,
> >> but just happens to use a model from that app for the testing of
> >> UtilsManager. The better way to improve this is to remove the
> dependency on
> >> the VOD app completely here and use a model that is in pr_services. See
> >>
> https://github.com/TireSwingSoftware/openassign-server/blob/83000836f764c440946157e1761d3f1aa4a1215f/pr_svc_tests/tests_svc.py#L2021
> >>
> >> --
> >> Reply to this email directly or view it on GitHub:
> >>
> >>
> https://github.com/TireSwingSoftware/openassign-server/commit/cef34bf2f97a24b27f9d31963f675a261ed7d6f1#commitcomment-668434
> >>
> >
> > --
> > Reply to this email directly or view it on GitHub:
> >
> https://github.com/TireSwingSoftware/openassign-server/commit/cef34bf2f97a24b27f9d31963f675a261ed7d6f1#commitcomment-668443
> >
>
> --
> Reply to this email directly or view it on GitHub:
>
> https://github.com/TireSwingSoftware/openassign-server/commit/cef34bf2f97a24b27f9d31963f675a261ed7d6f1#commitcomment-668447
>