chucknorris/roundhouse — comment on commit 663f6c2030c3f9db08e248de1f1daf58d9cc5836
File: product/roundhouse/resolvers/ScriptfileVersionResolver.cs line 20
By ferventcoder:

I would almost agree. Yes, it is a little more responsibility on the resolver, but in configuring itself given an object. I don't necessarily see that as too much responsibility since like you said, it is kind of splitting hairs.

The idea here leans towards OCP in that if later we want another configuration value passed we would need to expand the constructor, changing the code in in two places. Since two of those items can be pulled by still passing the configuration, it makes sense to reduce that down to just passing the object itself instead of primitives values of the object. Then we insulate changes a bit more, which is great for maintenance.

Does that make sense?