theuni/xbmc — comment on commit 2daa4f49bc92bb44f954f9444d7f62d0967b26d0
File:  line 0
By theuni:

@topfs2: I guess I should've been more clear upfront.. noflip is going to have to be for VIEWPORT_ON_CHANGE for sure since it can stop rendering. And that's what we're working towards here, making a reasonable default for Eden. Improving the other modes isn't nearly as important now imo. Would be great if I could catch you on IRC this weekend so we can hash this out in realtime, as I'm still not following your reasons for concern.

After taking another look, I think the cleanest way to avoid the extra renders is to set m_solver to 0 in SelectAlgorithm() for the fullscreen viewport modes. Then it's nice and clean, and the tracker doesn't actually do anything any different based on the mode.

@jmarshall: I'm not sure that we need to set noflip anywhere in the d-r code, looks to me like we can always glean it from whether or not there's a dirty region. In the case of VIEWPORT_ALWAYS, we always return a region the size of the full viewport, so mode 0 would still be 'always flip' (assuming we remove the as.xml variable).

If we can't get this hashed out by the end of this weekend, we'll need to just drop it for Eden. But that'd be a shame, so I'll do my best to see to it that that doesn't happen. I'll revert several commits here and add new ones on top.