mgersting/Taffy — comment on commit e4ffd0f430e75a9ca27cfdaf4e2a2d196742412a
File:  line 0
By atuttle:

Sorry it's taken me so long to look at this.

One issue I see is that in addition to the `taffy:aopbean` metadata attribute, you're also referencing `taffy:uri`,`taffy:cacheunit`,`taffy:cachetimeout`, etc for some implementation-specific details...

I logged [a bug](http://cfbugs.adobe.com/cfbugreport/flexbugui/cfbugtracker/main.html#bugId=86749) with Adobe a while ago, but essentially it boils down to this: CFML supports colons in attribute names, but CFScript does not (except in the javadoc comment syntax, which I hate with every fiber of my being). To get around this, Taffy supports both colon and underscore where colons would be used; so `taffy:uri` will also work as `taffy_uri`. I think your code should also reflect this.

I see why you switched representationOf to public. While it does "expose" an api method that was originally intended only to be used by methods in the subclasses, I don't see an easy way to accomplish the same thing.

The other thing to keep in mind is that this is open source software. "Good enough for now" is always an option! :)

Once I hear back from you on the colon-vs-underscore issue, I'll be ready to merge this in and include it in Taffy 1.1.