clebergnu/autotest — comment on commit efafb38170aae7dec4a099879532b4fa554fae4d
File:  line 0
By lmr:

I found issues that trace back to this commit:

[lmr@freedom autotest.lmr]$ check_patch.py -g 39
22:33:00 INFO | Checking github pull request #39
22:33:00 INFO |
22:33:10 ERROR| Found syntax issues during 'run_pylint.py client/virt/kvm_installer.py'
22:33:10 ERROR| [stdout]: Unhandled exception in VariablesChecker: list index out of range
22:33:10 ERROR| [stdout]: Unhandled exception in VariablesChecker: list index out of range
22:33:10 ERROR| [stdout]: Unhandled exception in VariablesChecker: list index out of range
22:33:10 ERROR| [stdout]: ************* Module client.virt.kvm_installer
22:33:10 ERROR| [stdout]: E0602:112:KVMBaseInstaller._qemu_bin_exists_at_prefix: Undefined variable 'prefix'
22:33:10 ERROR| [stdout]: E0602:130:KVMBaseInstaller._qemu_img_bin_exists_at_prefix: Undefined variable 'prefix'
22:33:10 ERROR|

They're pretty easy to fix though:

diff --git a/client/virt/kvm_installer.py b/client/virt/kvm_installer.py
index 5383b04..6bebd87 100644
--- a/client/virt/kvm_installer.py
+++ b/client/virt/kvm_installer.py
@@ -109,7 +109,7 @@ class KVMBaseInstaller(base_installer.BaseInstaller):
if result is not None:
logging.debug('Found QEMU binary at %s', result)
else:
- logging.debug('Could not find QEMU binary at prefix %s', prefix)
+ logging.debug('Could not find QEMU binary at prefix %s', self.install_prefix)

return result

@@ -127,7 +127,7 @@ class KVMBaseInstaller(base_installer.BaseInstaller):
return qemu_img_bin_name
else:
logging.debug('Could not find qemu-img binary at prefix %s',
- prefix)
+ self.install_prefix)
return None

Please correct the issues, meanwhile I'm still reading your patches.