djzort/torrus-newfeatures — comment on commit 5235b0a26c3e70f0ab55c860f5f3fb267834a396
File:  line 0
By djzort:

did you get an email from github about changes on my branch?

if thats the case, let me assure you that i didnt initiate it as i have
promised that i will not send you more requests. i have also promised to
continue to publish my changes as a courtesy.

i will happily change whatever settings in github are needed to prevent
it from further notices to yourself.

as i have continued to merge your changes, you should have no problems
at all merging the netapp and hp proliant changes to your master. i have
also updates your use of 'new' (which i see you acknowledged as being a
problem in your master).

however, keep in mind that i havent sent you a pull request and as such
make no promise that the changes are useful.

as food for thought, the way you have approached the DevDiscover modules
is a bit strange and doesnt allow a person to run 'perl -c' over the .pm
files. if you were to create a base class, and have all the discoverers
(for example) "use base 'DevDiscover::Base'" - you could make the
discovery modules more simple and robust, require less code and also
compatible with 'perl -c'

On 20/10/11 07:29, Stanislav Sinyagin wrote:
> On Wed, Oct 19, 2011 at 9:58 PM, Dean Hamstead
>
> wrote:
>> please be more specific
>
> I think we discussed it a hundred times already. Your branch is
> completely untraceable, and I won't have a chance to merge your
> changes into my branch. Because your changes are too intrusive (moving
> paths, deleting all extra space, and other things which don't make the
> software better, but make your branch completely unmanageable for me).
>

--
http://fragfest.com.au