jnunemaker/twitter — comment on commit b74770ef19524a925012c1d2ae7181e47fd49205
File:  line 0
By dkubb:

@sferik you asked for feedback on this commit via twitter, so ...

One thing I would caution against is mutating the arguments to a method, including a constructor. I've seen tons of subtle bugs pop by using `Hash#delete` on Hash arguments because you're modifying the object in the caller's scope, an object which may be used elsewhere.