maqetta/maqetta — comment on commit 54d1912d94eee2453ea46b6d84c59577527e622a
File: maqetta.core.client/WebContent/orion/editor/contentAssist.js line 17
By peller:

they're basically doing what Dojo has done in transition -- provide global names (orion.*) for their code, as well as returning a reference from the define method for AMD (see bottom of file) I don't mind if they continue doing both, but ultimately I'd prefer we use AMD with their code.

Unfortunately, both paths are broken: their orion definition, above, gets lost as a local variable in our loader, since the Dojo loader takes the text of the module and wraps it with a closure (AMD syntax) therefore, it's impossible to reference the code globally. The return at the bottom returns the package object orion.editor rather than the object being defined in this module.

Add to this that they don't follow the 1:1 mapping of module to Object observed by Dojo... not sure whether that's a Dojo convention or part of the AMD spec.