sakrafd/tire — comment on commit 6bb65d19e658b4f7bc5003e1e1167a49f0614acb
File:  line 0
By sakrafd:

No worries, as the repo owner it's up to you to decide what should be part of tire and what shouldn't. To answer you points:

1) I attempted to add a case similar to the "try again when an exception occurs" in Tire:IndexTest but couldn't come up with a good thing to assert. Running the suite with the environment variable set showed the functionality.

2) I don't know the internals of ES, which is why i used "seems to happen" in my comment - I was referring to why I thought ES would timeout for long periods of time. I'm ran a script to load my initial data into ES through tire and lots of timeouts DID happen. "update_mapping \[user\] (dynamic)" statements were the only thing that showed up in the ES log when they were occurring. My script would crash due to the current retry 5 times and die logic in tire's bulk_store. I assumed the retry logic was an attempt to work around timeouts. The additional sleep time gave ES a chance to catch up and my script could continue importing docs.

3) I wouldn't want to increase the timeout in ES for every request - I only saw them with the Bulk API. I could be wrong, but I don't think there is a way to increase the timeout for only this api in ES.

Anyway, no problem if you don't want to include this patch in tire. It was useful to me and I thought it might be a useful addition.