olegz/spring-integration — comment on commit ec0a709d2b94f41bdd33fe3ace7e0039b09e2f76
File: spring-integration-file/src/main/java/org/springframework/integration/file/remote/session/CachingSessionFactory.java line 94
By olegz:

Yeah, just fixed it.

Now in spirit of not going through the email here is the problem I am staring at now.

In FTP/SFTP adapters we have 'cache-sessions' attribute which is set to 'true' by default. If we set it to 'false', the DefaultSessionFactory will not be wrapped into CachedSessionFactory which I just modified. In other words adding attributes is easy, but I don't want to create mutual-exclusivity unless there is no other way. Personally I think we should have not exposed 'cache-sessions' attribute and instead let user to wrap their SessionFactory into CachingSessionFactory, than this would be simple, but right now since it is controlled by the 'cache-sessions' I was wondering what do you think about deprecating it. This way we would still support it and add the appropriate parsing code, but at least would start moving away from it.