elvuel/oauth2-invest — comment on commit a4cfb2d77cc65891d5b503276ca97c481644a399
File: init.rb line 28
By lplanas:

I'm not sure if using a middleware is the most maintainable approach
in this case, since we are splitting auth in to places: the
authenticator lambda in app.rb and the middleware.

I would prefer to have all auth methods consolidated as class methods
in a utility class that we can delegate to from the authenticator
lambda.

I see if auth is successful you call the specific web app through its
rack interface. That's definitely clever, but I'd prefer to handle the
request flow using HTTP redirects, as usual with OAuth2 schemes.

The thing is, if a user logs in any of our apps, he should
transparently be logged in in all of them, so he needs to enter user
and password just once. We would need to investigate how to do this in
a safe way.

On 13 Oct 2011, at 04:08, elvuel

wrote:

> roger, so that's it, thanks! marked+1
>
> --
> Reply to this email directly or view it on GitHub:
> https://github.com/elvuel/oauth2-invest/commit/a4cfb2d77cc65891d5b503276ca97c481644a399#commitcomment-648230