acidmoose/cloudname — comment on commit 4a287e304e0315517a5cb1750349b283d7c1f4d1
File:  line 0
By borud:

Looks pretty good. +1 for having Javadoc for everything. Would replace types with enums. Also if/else constructs are usually an indication that the code should be rewritten to use guard-style, switch or similar. You can almost always replace an "else" . (If you look at the rest of the Cloudname codebase there are 10 else-statements in 7200 lines of code).

(we could probably dispense with the Type-thing completely and infer the type by inspecting Field. the argument against doing this is that later we might want to add types like "file", "url" etc. if you feel like removing the type and inferring it from the Field class, that should be okay. we can do "file" and "url" differently when and if we need it)