bkubicek/Marlin — comment on commit 4589ab3f860cfc4c22060412e86434b49f9ff533
File:  line 0
By bkubicek:

Thoose 6 will very soon be the majority, because the new panel will be quite cheap. Also, this menusystem is usable on all repraps, even yours, with minimal changes (that I will do in a couple of days), just adding 3 buttons or a click encoder. I rather have one lcd library than 2 that share the same routines, especially if anything is changed in the way the lcd is addressed (e.g. by merging jundereys lcd branch!). The new lcd uses much less memory due to its non-abstracted class design, it tuned for performance (will be even more after dropping the arduino lcd library), and from my point of view it is a candidate for integration in all other reprap firmwares after a few more stabilizing iterations.
The menu per default and without interaction displays a page that just shows monitoring data. And this is the place where your stuff should go. Otherwise it is not supportable in the future. At least not from my side.
And, speaking about etiquette. From my point of view, what you did is very similar to being invited to a party, going to the toilet, finding out that the toilet paper roll is hanging the wrong way, turning it to your style, and then complaining if the house owner returns it to his preferred state.
You did not even give me the choice to accept or reject your code. Normally, thats considered hostile. You do a fork, you change it, you do a pull-request.
Thats what git is all about. Still, I don't want to revoke your commit rights, but please, again please, do it in a way that does not go against my intentions, as this is my fork.
And I could not care less about smartgit. I use git, git-cola, gitk, kdiff3, and still your commit would have been not helping by the shear design.