rhelmer/socorro — comment on commit f831575c70cd6336177ee35f31422f69cf258322
File:  line 0
By rhelmer:

I guess it's a good sign that most of your comments are about the test (which I copied from the testBuilds.py) :) I'll do a pep8 run over both files before putting up for review, and will convert from BS to lxml.html too. We do need to worry about deploying this to prod though, do you know if the RPM is relatively up-to-date? It's going to be painful to deploy if we have to do it any other way right now.

In general I dislike the way unit tests work in Socorro, I think we should establish something a little more normal, based on standard tools like mock. If you have time to do any of this please feel free! I could see doing a wholesale refactoring of the existing ones as a separate commit, alternatively.

I feel like ftpscraper could be refactored a bit to be more testable, for example all the version-detection stuff buried in the "scrape" function, that could probably be broken up into 2 or three functions instead. I'll give this a shot too.