longlho/hudson-s3 — comment on commit 016c2d9c62ae94ceae801beb87741f9ede284248
File: src/main/java/com/hyperic/hudson/plugin/S3Profile.java line 72
By d6y:

OK - as bucket names in S3 can't contain a / and, this seems fine to me. We
just need to fix up the logic to handle 0, 1 or more slashes. Want me to
put together a test case, or are you on this?

BTW - the Amazon S3 Client refactoring looks good: much less code! Thank
you

On 12 October 2011 13:44, Long Ho <
reply@reply.github.com>wrote:

> Sorry for the confusion. The intention here was that you can specified
> object path in the BucketName box (i.e for the use case I used was
> artifacts/appName/$SVN_REVISION so I only split twice, the 1st entry is
> artifacts and the rest is appName/$SVN_REVISION).
>
> Since amazonaws driver only takes in bucket name as the 1st arg in
> putObject, I had to do a string split. The filePath.getName is to get the
> artifact filename only. So for my case I'll end up with uploading to
> artifacts/appName/$SVN_REVISION/webapp.war for example.
>
> Yup there's a bug there when bucketName doesn't have a "/" or "\". I should
> check for the length of bucketNameArray before proceeding.
>
> --
> Reply to this email directly or view it on GitHub:
>
> https://github.com/longlho/hudson-s3/commit/016c2d9c62ae94ceae801beb87741f9ede284248#commitcomment-646574
>