xbmc/xbmc — comment on commit 8b70fed2a9109f73e42cad4fce73fd60f487059b
File:  line 0
By opdenkamp:

I saw you already done these changes, thanks!
Now, it didn't come in in a rush, but the original PR has been around
for about a month. I just updated the lib to a newer version, which adds
win32 and darwin support for instance. I didn't change the public
interface much (just a few renamed properties and methods), so not much
has changed in how it's implemented. Now the dependency download wasn't
good, and that's been reverted, and while doing that, I messed up 1
check in configure.in (which I'll fix today).

Op 11-10-2011 10:01, wsoltys schreef:
> why does this come in in such a rush? Parts are completely wrong and I wonder if they are tested on win32?
> 1) I would like to keep #ifdef HAVE_LIBCEC and define it for win32 in system.h
> 2) no dll belongs in the lib folder. If they are implicit linked they have to be in the dependency folder that the installer can pick them up. Second I would try to delay load it to move those dlls in the system folder (then no copy to dependency and to the debug folder is necessary).
>
> I'll see if I have some time to fix that but I'm not very pleased with it.
>