pcc/CMake — comment on commit 378d99d7910f50db0b7f85408f8b1468307f4b64
File:  line 0
By polrop:

On Sun, Oct 2, 2011 at 8:33 PM, pcc

wrote:
> On Thu, Sep 29, 2011 at 01:03:59AM -0700, Nicolas Despres wrote:
>> I was tempted to do that from the beginning but I'm still wondering whether some differences will not show up while trying to port the generator to other compilers/platforms. We will see...
>
> Even if differences do arise, I think it's far better to take care of
> those differences with an "if" statement than by modifying something
> in one of three subclasses with mostly duplicated code.
>
> If you look at the history of the
> cmMakefileExecutableTargetGenerator.cxx and
> cmMakefileLibraryTargetGenerator.cxx files you will see that a large
> number of changes are essentially doing the same thing to both of the
> files, which isn't very nice from a maintainability point of view.
>

I definitely agree with you and I planned to factor all that code once
I would have something working. Anyway, it is just a matter of
planning :-)

Cheers,

--
Nicolas Desprès