pcc/CMake — comment on commit efeea36c653fb9ad990d0ab3e32958d18abf97ba
File:  line 0
By polrop:

On Sun, Oct 2, 2011 at 9:43 PM, pcc

wrote:
> On Thu, Sep 29, 2011 at 01:51:25AM -0700, Nicolas Despres wrote:
>> Either this module was bogus or the Ninja generator. But changing a module to please a generator looks weird to me.
>
> This module deliberately built an incomplete dependency graph by
> declaring custom command dependencies which neither exist nor are
> declared as an output, to prevent its custom commands from being
> added to multiple targets. The author didn't explain his reasoning
> in the comments too well, but I'm guessing it works around a parallel
> build issue with the other generators when adding custom commands to
> multiple targets. Fortunately this isn't a concern with the Ninja
> generator, which only creates one build statement per custom command
> no matter how many targets it belongs to.
>
> The KDE build system creates a similarly incomplete dependency graph,
> except with source file inputs instead of custom command dependencies.
> I resolved that issue using assumed source dependencies (see commit
> 9b6582ccb561e0004cc8516cdc326d60ff5e07f9), but since custom command
> dependencies cannot be marked as GENERATED I can't use a similar
> solution here.
>
> We might need to modify this module to do something conditionally
> for the Ninja generator.
>

Ok. Thanks for the explanation. Maybe the author will react on this issue.

--
Nicolas Desprès