yihuang/HTTP — comment on commit 2ecc3f323a27c06b7ca6236e6c7b60e5e9aafa37
File:  line 0
By hsenag:

Hi,

Thanks for the suggestion. setRequestBody definitely looks useful, though I'm not entirely sure whether the backwards compatibility break to postRequest is worth it.

While setting the body, shouldn't we also encourage the user to pick a content-type? The HTTP spec (RFC 2616) says "SHOULD" for this header.

Also, I'm currently asking for code changes to have associated tests (e.g. regression tests for any bug they fixed, or tests of new functionality) before they get committed.

Cheers,

Ganesh