dlitz/pycrypto — comment on commit 7325a2b757612afa766464d4d9ae5cb3ed31711d
File:  line 0
By dlitz:

On Mon, Oct 10, 2011 at 03:31:13PM -0700, Legrandin wrote:
>Are you sure you really need autoconf for this?
>
>I got away with it by simply checking libgmp version in _fastmath.c with a simple define:
>
>#if (__GNU_MP_VERSION>=5)
>
>https://github.com/Legrandin/pycrypto/commit/5578f3e1649ca809055cec642eac2568b7d24aab

Sure, I guess that would work for GMP, but what happens if/when MPIR
decides to add mpz_powm_sec?

There seems to be a general need for some build-time autoconfiguration:

- gmp vs mpir vs slowmath
- mpz_powm_sec vs mpz_powm
- multiarch

I suspect it's better to just implement autoconf (and special-case MSVC),
rather than hand-code individual checks into setup.py.

--
Dwayne C. Litzenberger
OpenPGP: 19E1 1FE8 B3CF F273 ED17 4A24 928C EC13 39C2 5CF7