BibLibre patches to be integrated for 3.4

BibLibre has pushed 636 patches to be integrated in Koha. They are all available at git.biblibre.com, in branches called 3.4/BibLibre-<modulename> 
For all branches :
- make test show no error
- perl perl xt/author/valid-templates.t runs smoothly
- this code is live for 3 of our customers (and large one), so the main problems should be in rebasing/splitting.
- our master branch on git.biblibre.com contains the original code. In case of a problem, you can compare files in both branches
Here is a description of what we have submitted : 
= Acquisition patches (#5580, pull request sent) =
New script to delete old suggestions (MT3000), other patches are bugfixes, minor changes 
http://acquisitions34.git.biblibre.com login test/test http://catalogue.acquisitions34.git.biblibre.com 
BibLibre branch 	description 	tested by 	status
BibLibre-acquisitions	acqui/acqui-home.pl 	Irma Birchall	No problems.
BibLibre-acquisitions	acqui/suggestion.pl 	 	
BibLibre-acquisitions	acqui/aqplan.pl 	 	
BibLibre-acquisitions	acqui/aqbudgets.pl 	Irma Birchall	The purpose for encumbrance and expenditure is unclear and it is unclear which values should be entered. Are these features coded? See Bug 4266
BibLibre-acquisitions	acqui/neworderempty.pl 	 	
BibLibre-acquisitions	acqui/addorderiso2709.pl	 	
BibLibre-acquisitions	acqui/basketgroup.pl 	 	
BibLibre-acquisitions	acqui/parcel.pl 	 	
BibLibre-acquisitions	acqui/lateorders.pl 	 	
BibLibre-acquisitions	acqui/histsearch.pl 	 	
== Other observations ==
BibLibres patches don't solve Bug 4438. Add a budget, a fund and a child fund, try to edit the parent fund (1st level). It is not possible to save changes to the fund, because of a wrong JavaScript alert. (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4438)
= Authorities (#5581 pull request sent) =
*adding a "default" authorities, and the possibility to search on "default". Thus, when a user don't know in which authtype what he is looking is, he will be able to search
* many fixes on UNIMARC 
* some general fixes & changes in templates
* missing = default marc21/en authorities
http://authorities34.git.biblibre.com login test/test http://catalogue.authorities34.git.biblibre.com 
BibLibre branch 	description 	tested by	status
BibLibre-authorities	authorities/detail.pl 	 	
BibLibre-authorities	Authorities search 	 	
BibLibre-authorities	opac-authoritiesdetail.pl	 	
= cataloguing (#5574, waiting_qa) =
*new granular perm to edit biblio/edit item 
*FA (fast cataloguing) accessible from circ when barcode not found if FA framework exists 
*in addbiblio, <enter> no more validates the record 
*Biblio bulkedit (like item bulkedit on koha 3.2) 
*various fixes
http://cataloguing34.git.biblibre.com test/test
BibLibre branch 	description 	tested by	status
BibLibre-cataloguing	granular permission (edit_items)	 	
BibLibre-cataloguing	rebuild_zebra.pl 	 	
BibLibre-cataloguing	biblio merging fixes 	 	
BibLibre-cataloguing	cataloguing/additems.pl 	 	
BibLibre-cataloguing	batchedit changes(items) 	 	
BibLibre-cataloguing	tools/inventory.pl 	 	
BibLibre-cataloguing	tools/z3950_search.pl 	 	
BibLibre-cataloguing	move_items permission changed 	 	
BibLibre-cataloguing	unimarc_plugins updated 	 	
= OPAC (#5584 request to pull sent) =
*coinS fixes 
*Perl 5.10.0 needed 
*new syspref to have some items automatically & always removed on OPAC 
*limitation by group working again (fix) 
*search history fix & improvement : limit taken into account
http://catalogue.opac34.git.biblibre.com/
BibLibre branch	description 	tested by 	status
BibLibre-opac 	opac/opac-detail.pl 	 	
BibLibre-opac 	opac/opac-user.pl 	 	
BibLibre-opac 	opac/opac-advsearch.pl 	Owen Leonard	The fix for MT3618, "search is duplicated" is a revert of an intentional change: duplicating the search controls makes them more visible for those who don't use all advanced controls. I recommend we modify the markup to make it possible to hide with CSS.
BibLibre-opac 	opac/opac-authoritiessearch.pl	 	
BibLibre-opac 	opac/opac-ISBDdetail.pl 	 	
BibLibre-opac 	opac/opac-searchhistory.pl 	 	
BibLibre-opac 	opac/opac-auth.pl 	 	
BibLibre-opac 	OpacHiddenItems syspref added 	 	
= Various =
http://various34.git.biblibre.com test/test
BibLibre branch 	description 	tested by	status	
BibLibre-various	multiple CAS authentication 	 	 	
BibLibre-various	bulkmarcimport improved 	 	 	
BibLibre-various	UNIMARC XSLT improvements/changes 	 	 	
BibLibre-various	deal with Mac/windows endofline in CSV profiles 	 	 	
BibLibre-various	overdue_notices improvements : exlude branches from notices, display branch names & not branchcodes, generate html (or plain text as previously, through an option)	 	 	
Note: this branch must (and will) be splitted in smaller patches, it contains some code very customer specific that should not be in official Koha atm, and does not result in a consistent branch.
= catalogue-circulation-members (#5575 awaiting_qa) =
This is the biggest part of the stuff : 300 patches. cat/circ/memb are highly nested, so it has been impossible to split them in smallest parts. 
Note : if you test MARCdetail.pl, you'll see that there is a javascript problem if you don't have merged BibLibre-admin. That's because admin adds tablesorter jquery extension, that is used in MARCdetail.pl, and it's not available in this branch. There is no other consequencies. You won't see the problem if you've BibLibre-admin already merged.
http://borrowers34.git.biblibre.com test/test
BibLibre branch 	description 	tested by 	status
BibLibre-memb-circ-upd	catalogue viewcard now compatible with UNIMARC 	 	
BibLibre-memb-circ-upd	duplicate a patron (new feature) 	Liz Rea 	Worked well for me, duplicated 1 patron into 3 members of a family. Also checked duplicating a record into a child record, and duplicating a patron into a child with a guarantor. One minor issue: the duplicated patron form does not auto populate the borrower card number like the original add patron interface does: as an example, add patron 1, you get an autopop cardnumber. Duplicate patron 1, and the new patron (patron 2) will not have a number assigned, even with the autopop syspref on. This is minor, since most places don't autopop cardnumbers, they scan them in. It is inconsistent behavior, however.
BibLibre-memb-circ-upd	purchase suggestion link in patron detail (new feature) 	 	
BibLibre-memb-circ-upd	displaying guaranteed issues on guarantor detail (new feature) 	Liz Rea 	No issues displaying guaranteed issues on guarantor detail.
BibLibre-memb-circ-upd	many changes in borrowers displays (new fields, reordering of fields,...) 	Liz Rea 	On pay.pl, the a fatal error: "Undefined subroutine &main::ModNote called at /home/koha/versions/3.4/borrowers/members/pay.pl line 91" when trying to pay fines. Replication video: http://screencast.com/t/wgpEMhZ9
Patch pushed today 2010-11-30 
Pushed to new/awaiting_qa/biblibre_memb_circ_upd --Chris 01:12, 30 November 2010 (UTC)
BibLibre-memb-circ-upd	rewritten hold/issues/fine rules = all at branch/itemtype/categorycode level + inheritance. Note that the "default" branch means "total" or "default" again, depending on wether there is a branch level value. For example default 10 items, B1 5 items (5 from branch B1, 10 overall), B2 nothing specified (= 10 items, default value)	 	
BibLibre-memb-circ-upd	hold now have a primary key 	 	
BibLibre-memb-circ-upd	show status & damaged of checked-in documents (new feature) 	Liz Rea 	Damaged status does not show when item is checked in using the check box on the check in page. I believe it should. The following error occurred when I tried to check in an item using the masthead check in function: Global symbol "$remotehost" requires explicit package name at /home/koha/versions/3.4/borrowers/circ/returns.pl line 228.
Global symbol "$remotehost" requires explicit package name at /home/koha/versions/3.4/borrowers/circ/returns.pl line 229.
Execution of /home/koha/versions/3.4/borrowers/circ/returns.pl aborted due to compilation errors. http://screencast.com/t/fWCBgEAYMlR7. And actually, now I cannot check in at all, even from http://borrowers34.git.biblibre.com/cgi-bin/koha/circ/returns.pl
Patch Pushed Patch pushed today 2010-11-30
Pushed to new/awaiting_qa/biblibre_memb_circ_upd --Chris 01:12, 30 November 2010 (UTC)
BibLibre-memb-circ-upd	new syspref : 'OPACPickupLocation','1','Allow choice for Pickup Library reserve at OPAC' (new feature) 	Liz Rea / nengard	No problems found. Works as advertised. / I just note that it should be 'hold' not reserve.
BibLibre-memb-circ-upd	CI-3M syspref for rfid security on/off (new feature) 	 	
BibLibre-memb-circ-upd	offline circ rewritten & improved : uses a firefox module available at https://addons.mozilla.org/fr/firefox/addon/14399/, user can upload all files when network back, and Koha merge all of them on order (new feature) 	 	
Almost all scripts have been modified in circ/reserves/patron
= Admin patches (merged into master) =
*only bugfixes or minor improvements (like table sorter everywhere where it's relevant) 
*removing link to new syspref => probably not to apply ! We faced many problems with the new system (with translations, that was inverting yes and no !!! and also with upload feature we have added and that we needed it. I suggest to revert this patch, work on upload syspref feature, and heavy testing of the new system in french !) Note that all our patches for new sysprefs in updatedatabase are related to old updatedatabase system, and will have to be ported to new system
http://admin34.git.biblibre.com login test/test http://catalogue.admin34.git.biblibre.com 
BibLibre branch	description 	tested by 	status
BibLibre-admin 	admin/category.pl 	Irma Birchall 	All features are working
BibLibre-admin 	admin/auth_tag_structure.pl 	Irma Birchall 	All features are working
BibLibre-admin 	admin/branch_transfer_limits.pl	Irma Birchall tested on 30/10/2010	
Undefined subroutine &main::mybranch called at /home/koha/versions/3.4/admin/admin/branch_transfer_limits.pl line 43.
(fixed)
BibLibre-admin 	admin/cities.pl 	Irma Birchall 	All features are working
BibLibre-admin 	admin/itemtypes.pl 	Irma Birchall 	All features are working
BibLibre-admin 	admin/branches.pl 	Irma Birchall 	All features are working
= Reports (merged into master) =
*fixes 
*adding choice of separator in CSV export (guided reports)
http://reports34.git.biblibre.com/ test/test
(note there are no datas on the DB)
BibLibre branch 	description 	tested by	status
BibLibre-reports	guided-reports (incl permission)	 	
BibLibre-reports	reports/issues_stats.pl 	 	
BibLibre-reports	reports/catalogue_stats.pl 	 	
BibLibre-reports	reports/borrowers_stats.pl 	 	
BibLibre-reports	reports/reserves.pl 	nengard 	We have agreed that reserves are called 'holds' also capitalization is inconsistent. The toolbar on the left is missing a link to the new 'Holds' stats.
= Serials (merged into master) =
* granular permissions added
* fixes & minor improvements
This has been merged into master after passing qa and basic testing, please test fully
BibLibre branch 	description 	tested by	status
BibLibre-serials	Each script has been modified (permissions)	 	
Category:Quality_Assurance_Testing
Category:3.4