Bug triage/2007-06-04

== Agenda (discussed) ==
=== Obvious to Fix One-Liners (Warnings, Style, Code-related, Micro-Buglets) ===
* - Reading length data for a four-byte Variable template message misstores the length - 
** obvious, needs fixing
* - Zero missing in Sub-unit snap grid. for small fraction like 1/16 and 1/32 - 
** obvious, one-liner, end user visible buglet, 3 votes
* - Compiler errors in llwebbrowserctrl.h - 
** obvious, one-liner, 3 votes
* - Some source files (llprocessor.cpp and llsdserialize_tut.cpp) contain non-ASCII characters - 
** obvious
* - Boost inclusion is inconsistent - 
** obvious
* - Calling DestroyWindow with NULL window handle (win32 version) - 
** obvioius, one-liner
* - lltemplatemessagereader.cpp: standard inclusion at top of source file - 
** obvious (just the usual header stuff and "linden_common.h" missing)
* - Trivial sizeof() miscalculatuion results in incomplete copying of CPU Brand ID string in CProcessor::AnalyzeAMDProcessor() - 
** obvious, one-liner
* - Dead members "eVertexDataMask;" in various objects - 
** obvious, 6 files, same one-liner in each
* - logRanOffEndOfPacket is too terse when it logs packet data, add some more info - 
** obvious, few lines of code (one hunk)
* - Crash in llscrolllistctl.cpp when sorting scroll list - 
** one liner, probably not a real bug in current version as he says, but good style
=== International Users ===
* - Change keyboard shortcuts, because entering { [ ] } on German and some other international keyboards (AltGr 7, 8, 9, 0) triggers Rendering Features accelerators Ctrl-Alt-7, 8, 9, 0 (previously resulting in unstable viewer) - 
** obvious, one file, 10 lines
* The next three should probably go together (someone addressing non latin DBCS-Unicode issue for the viewer)
** - Unicode supplementary characters typed in from keybaord are not handled properly on Windows (and potentially on Linux) - 
*** three files, six hunks, but this problem must be a real PITA for asian users
** - Cut-and-Paste of Non-ASCII characters to old Applications doesn't work well on Windows - 
*** a few lines deleted, seems reasonable
** - Keystrokes are eaten by IME when no text input is possible, on Windows using Japanese - 
=== Language/Translation ===
* - German Translation of the Viewer inaccurate and sometimes dangerously wrong - 
** that's pretty damn true :-)
* - Swedish translation - 
** that must have been a lot of work!
* - Permissions of Roles and Rights messed up in all translations of official skin - 
** 4 votes
* - Incorrect menu item referred to when member of maximum number of groups and a group invite is received - 
=== Bugs and Buglets ===
* - Particles -> Burst Quantity -> Fades -> as of 1.14.x - 
** not really a to patch in as it is, more of a starting point to address the issue (although it works better than the stock viewer already). 17 votes plus a more from dupes and related
* - When turning off Flexible Object rendering, flexible objects become permanently invisible - 
** not sure if what this fixes is a bug, but it would be worth changing if VWR-349 is not addressed (European users losing rendering of all flexis whithout knowing why).
* - seg fault in lldrawpool.cpp - 
** three hunks, two outdated, one valid (although probably of little impact). avoids null pointer access, have seen crashes from similar stuff. The one hunk for 1.16 (couple of obvious lines) is separately available
* - Inconsistency in order of AV texture layers between the upper body, lower body, and head - 
* - Inexplicable folding of Avatars such that they are walking around with their heads up their arses - 
** 9 votes
* - Object editing arrows hidden but clickable on objects you can't edit. - 
** 4 votes
* - indra.l: the code to parse constants is too loose. - 
** 4 votes
=== Linux and Platforms ===
* - htonmemcpy doesn't get the LL_BIG_ENDIAN macro, so fails on big-endian architectures - 
* - en_US.utf8 is not guaranteed to be a compiled locale - 
=== Late addition ===
* 
== Agenda (ran out of time) ==
* - Don't bother building the crashlogger binary in an opensource build - 
* - Support linux platforms other than i386 for llfasttimers - 
* - ELFIO is technically optional, make this easy to capitalise on - 
* - slviewer doesn't use db-4.2 - 
* - indra/llwindow/files.win32.lst: add llkeyboardwin32.cpp, llwindowwin32.cpp - 
* - need Second Life Viewer compiled under Solaris x86 and SPARC - 
* - confusion with LL_WINDOWS|LL_LINUX|etc being used to select target platform and assumed compiler - 
=== Sconstruct ===
* - SConstruct script makes many assumptions that are invalid outside LL - 
* - SConstruct improvements - 
* - SConstruct: create newview lib before final link - 
** 3 votes
=== New Features/GUI ===
* - PNG image support submission - 
** requires libpng library? 25 votes
* - Logging Chat to Disk does not include timestamps - 
** 11 votes
* - Patch to Address Debit Permission Spoofing - 
** 7 votes
* - Automatically start renaming new user-created assets and automatically select new user-created folders - 
** 7 votes
* - Patch to make View Admin Options sticky - 
* - Abuse report tool should autofill abuser name when reporting an object - 
** 6 votes
* - Added new menu item: Tools > Edit Linked Parts - 
** 5 votes
* - If a Find/Search returns no results, the results list is still focused and an attempt is made to select the first result anyway. - 
** 3 votes
* - Get rid of "Return All" - 
=== Already someone working on? === 
* - Viewer memory leak (over several hours) - 
** 145 votes
* The next three are related (same point in source), have been reported to Steve directly
** - Change Request: Excess texture buffer memory size resulting in disk thrashing/crashes/virt memory swapping - 
** - Unnecessary blurry video/textures with low end graphics cards - 
** - Buggy condition statement appears to cause texture related bug side effects on systems with > ~2GB RAM - 
*** 8 votes
=== Assorted ===
* - Tools / Reset all Scripts in Selection Window does not Scroll automatically - 
* - A harmless compiler warning in indra.l.cpp - 
* - LLMozLib not cleaned up/deleted at end of program - 
* - Inconsistent behaviour between agent_slide_left / agent_slide_right, and the rest of the movement functions. - 
** 5 votes
* These two could probably be combined or are the same?
** - VC8 solution is missing files - 
** - Visual Studio 2005 Solution and Project Files - 
* - llBase64ToInteger caveats & bugs - 
** Should be looked at, since it apparently involves a bug where uninitialized data is referenced
* - Replace HTML Help with Harry Linden's Google Co-op search, or add a button to the HTML Help window to go thee. - 
** 4 votes
* - Patch for separate color for llOwnerSay - 
** 6 votes
* - md5 slow - 
** probaby a "won't fix"
* - Torn of IM windows should be minimizable - 
** according to the release notes, the related was fixed in 1.15.0.2 ("Fixed detached IM windows not resizing"). Not yet fixed Minimizing, but no spearate patch attached.
== Transcript ==
[15:01]	: 	hi, Rob!
[15:01]	: 	Howdy, Rob!
[15:02]	: 	hi everyone!
[15:02]	: 	Hi Rob
[15:02]	: 	Hi, rob
[15:02]	: 	we think you have a long agenda
[15:02]	: 	'afternoon everybody :-)
[15:02]	: 	this is really cool....lots of people who normally are on the list
[15:03]	: 	It's morning for me
[15:03]	: 	pretty early there, I imagine
[15:03]	: 	7 in the morning
[15:03]	: 	Yuck ... well midnight here :-)
[15:04]	: 	6pm for me.. I skipped out of work early to come to the triage :)
[15:04]	: 	Hey Nick!
[15:04]	: 	I'm not sure why that envelope insists on levitating today
[15:05]	: 	anyway
[15:05]	: 	do you see people above Birdie?
[15:06]	: 	so, a lot of the patches that Nicholaz marked "obvious" I doubt I'll dispute
[15:06]	: 	https://wiki.secondlife.com/wiki/Bug_triage/Agenda
[15:07]	: 	Well, most of the comments there are mine I think (dunno if anyone else added their own), so they may or may not apply.
[15:07]	: 	anyone disagree with Nicholaz on those?
[15:07]	: 	obvious ones?
[15:07]	: 	No, I agree most of them are quite small and likely safe code changes.
[15:07]	: 	the first section of the agenda here: https://wiki.secondlife.com/wiki/Bug_triage/Agenda
[15:08]	: 	let's skip to then...
[15:08]	: 	560 is an obvious one, isn't it ?
[15:09]	: 	put under "Obvious" title, but no "obvious" in its comment.
[15:09]	: 	Nicholaz, you had it marked as just a style thing
[15:10]	: 	I think obvious in the sense that if you check the index, you might as well check for >=0 ... but since the guy said it only happened in ...
[15:10]	: 	in one of his own combinations, I'd say either put it on or mark "don't fix".
[15:11]	: 	ok, fair enough....I'll import it and let someone else decide
[15:11]	: 	
[15:12]	: 	btw: anyone object to me taking a transcript of this and posting to sldev?
[15:12]	: 	Thank you, Japanese people cant type Ctrl-Shift-1 easily
[15:12]	: 	Nope.
[15:12]	: 	No.
[15:12]	: 	Gigs Taggart wanted a transcript, and so I figure I'll make it for everyone
[15:12]	: 	349 is basically obvious as well. question is if you want to break the habit for those who use these shortcuts vs. ...
[15:13]	: 	having unexpected side effects for those who use the Alt+Gr key for brackes (I had three or four people ....
[15:13]	: 	from Europe already contacting me about that directly)
[15:13]	: 	Like it could takes a preference to choose between 1 and F1 series ?
[15:13]	: 	Sort of that. Or I don't know if those combos work on Macs or Linux
[15:13]	: 	does this patch affect all users?
[15:13]	: 	I believe supporting existing localized keyboard is more important than keep shortcuts.
[15:14]	: 	I think if the troublesome shortcuts don't remap to another debug function, it's better to avoid quirky AltGr behavior even if it means having some people relearn some shortcuts.
[15:14]	: 	It affects those users who use specific features from the Debug menu.
[15:14]	: 	a workaround for the Japanese would be to put Ctrl-Shift-1 in the menus where the other Ctrl-Shift-#s are
[15:14]	: 	(in that they need to adjust to new keys)
[15:14]	: 	IMHO, the source of this bug is not the code; it is the design.
[15:15]	: 	the guy who assigned this shortcut should be terribly ignorant about the international keyboard users.
[15:15]	: 	The shortcuts I used (ctrl+alt+F-key) were just the nearest I could find. The point is for Europeans to get away from Ctrh+Alt+Digit
[15:16]	: 	we could say this is not a bug, but anyway users of international keyboard need some solution.
[15:16]	: 	ctrl-shft 1-9 are all debug menu shortcuts, then? I just want to make sure this isn't stomping anything that has a surprisingly large audience
[15:16]	: 	Problem impact users using special characters, like a lot of non-US people, patch affect every users using debug shorcuts they need to relearn.
[15:16]	: 	I would think C-S-1 would be in Client/Consoles
[15:16]	: 	Yes, they're all debug menu shortcuts.
[15:17]	: 	(in the third menu level of the debug menu ... I didn't even knew they existed)
[15:17]	: 	There are already at least onf Ctril-Shift-F2
[15:17]	: 	well, you can tell I use them every day :)
[15:17]	: 	ok...I'll import it. looks like it at least is worth a look here
[15:18]	: 	Another alternative would be to disable their effects if the debug menu is off. (which would work for 98% of the users probably)
[15:18]	: 	Random assignment of shortcut is always dangerous
[15:18]	: 	next up:
[15:18]	: 	Alissa, that's you :-)
[15:19]	: 	Well, it's mine. :-)
[15:19]	: 	quick tangent....can everyone see the list of who else voted on an issue?
[15:19]	: 	I saw 459 and it looks good. Have it in my own build and have not heard of adverse effects.
[15:20]	: 	Naturally, I support to import this :-)
[15:20]	: 	oh...it was already imported
[15:20]	: 	But I guess 459, 177 and 251 go together if someone is lookig at that stuff anyway.
[15:20]	: 	ah, ok
[15:20]	: 	One possible problem is a design tradeoff
[15:20]	: 	(Yup, can see who else voted too)
[15:21]	: 	can someone link these issues together externally?
[15:21]	: 	I'll do the same for the issues when I import them
[15:22]	: 	can do.
[15:22]	: 	These three have no relationshipt except that they all are related to Uniocde handling
[15:22]	: 	Unicode
[15:22]	: 	great, thanks!
[15:22]	: 	Technically, they handle different issues in different ways
[15:23]	: 	k...looks like they're all already imported, but may not all be linked
[15:23]	: 	I'm not so sure why these three should be handled together
[15:24]	: 	Oh okay. It was just the idea if someone looks at asian data entry/uincode anyway they might well go togehher.
[15:24]	: 	459 and 177 may look similar, but the patch for 251 is totally different taste
[15:24]	: 	next up:
[15:24]	: 	Ok.
[15:25]	: 	I haven't looked at the specifics of that patch, but when I saw the German version first time with a friend, it was ... umm ... odd.
[15:26]	: 	Someone fully understand german should check the correction.
[15:26]	: 	I'm not eligible
[15:27]	: 	the title and description of the bug is written in such a way as to make it a "never ending bug", but it's very good that there's a patch there
[15:27]	: 	I can do that, but from the example he gave like they thranslated "Properties" to the equivalent of "Real estate" I assume the guy was a native speaker.
[15:27]	: 	But I can look at it.
[15:28]	: 	Rob, Linden Lab has some German speaking Liaison
[15:28]	: 	Can we ask some of them to see the fix?
[15:29]	: 	I'll just import the issue, and let the i18n team take a look
[15:29]	: 	: w00t
[15:29]	: 	I'll import
[15:30]	: 	Same thing. we need someone fully understand Swedish
[15:30]	: 	given the initial characterization of the translation, we probably won't just blindly release a product with it, but it's good to get it on the radar of the i18n team
[15:31]	: 	I just checked the 1st quarter of the German translataion. It's definitely an improvement and correct.
[15:31]	: 	has already been imported
[15:31]	: 	ooops... excuse me
[15:32]	: 	
[15:32]	: 	Will the changes to the permissions in need to be appliedto the Swedish translation in 774?
[15:32]	: 	Able: probably, but from the sounds of things, 774 is just a first draft anyway
[15:33]	: 	238 patch is only adding a 'value' attributes to ~40 lines
[15:33]	: 	...and there's probably other stuff that needs to be applied
[15:33]	: 	Okay, I just wanted to point it out so that the new Swedish translation doesn't suffer from odd permission issues.
[15:33]	: 	Translations are getting out of sync more and more, patch after patch.
[15:34]	: 	Yes. I have pointed out it on sldev.
[15:34]	: 	and the answer from Jean Linden was that Lindens somehow handle it...
[15:34]	TT Lingiuan wonders if foreign language inworld groups have people who would be willing to help translate 	TT Lingiuan wonders if foreign language inworld groups have people who would be willing to help translate
[15:35]	: 	I fear we are locked with 'bad' translations until the i18n tools are completley done...
[15:35]	: 	i18n tools? what that?
[15:36]	: 	Like translations coming from a wiki page being inserted in the en-us version to get translated Xui
[15:36]	: 	well, I haven't been following too closely, but I know that Jean et al have been trying to figure out the best way to collaborate with the community on translations
[15:36]	: 	Ok.
[15:36]	: 	This is a by-talk, but Japanese translation has some problems
[15:37]	: 	and there are some Japanese speaking residents who are willing to work on it
[15:37]	: 	the problem is at this moment, there are no good process to do so
[15:37]	: 	isn't a patch, but a set of replacement files, it seems
[15:37]	: 	...which could be a problem
[15:38]	: 	I'd say with diff-patches it should not be too hard to get things fixed by residents.
[15:38]	: 	Alissa: I'll ping Jean on the subject
[15:38]	: 	Could most likely be converted to a diff patch, seems likes a single world change. Purely visual candy
[15:40]	: 	any volunteers to convert to a patch?
[15:40]	: 	Question about i18n is, if people gather and create up-to-date translations, how will it be handled back by LL ?
[15:40]	: 	Sure, I can do that for 746.
[15:40]	: 	Able: thanks!
[15:41]	: 	Nou ... yes, if it sits on the Jira for three months, people will lose interest soon.
[15:41]	: 	That's one of the reason residents are no so excited on the issue, Nounouch
[15:41]	: 	Nounouch: that might be a good topic for a different office hour. I'd like to make sure Jean or someone else is around for that (I can't remember if she holds office hours)
[15:41]	: 	They don't ^^
[15:41]	: 	(yet ;) )
[15:42]	: 	Same goes for non language patches. just look at the VWR-Numbers for those obvious things.
[15:43]	: 	recent hiring should help address that issue. I'm being intentionally vague here, but I think we'll get this sorted out soon
[15:44]	: 	I havn't checked "BUg and BUglet" section...
[15:44]	: 	Who did LL did buy ? ;)
[15:44]	: 	Windward Mark
[15:45]	: 	Well, with bugs and buglets, I think 412 is fixed (saw that on 1.17 release list today)
[15:45]	TT Lingiuan likes the less shaded reality -- uh oh 	TT Lingiuan likes the less shaded reality -- uh oh
[15:45]	: 	http://lindenlab.com/press/releases/05_21_07
[15:45]	: 	660 can be ignored if you change the shortcuts for those debug menus.
[15:46]	: 	hey a more realistic physics model would be better than advanced fog technologies, but I understand that would create server-side lag
[15:46]	: 	Does 53 have any drawback on current designs ?
[15:46]	: 	132 is similar to that last one in the obvious section (about cheking the coumn indices). Nice to do checking for a NULL pointer, but no real impact at the moment.
[15:47]	: 	Oops, I'm off track :p
[15:47]	: 	I have not checked 53, sorry.
[15:47]	: 	Actually looking at the patch for 660, I think it's a different issue than the keyboard acclerator problem.
[15:47]	: 	"Disabling Flexible Object Rendering will cause flexible objects to disappear until the user leaves and returns to the sim or logs out and logs back in. "
[15:47]	: 	I think what he says is that he wants to change what Ctrl+Alt+8 does.
[15:48]	: 	
[15:48]	: 	660 reduce 349 impact by not hiding flexi, as a side effect ?
[15:48]	: 	No, it looks like the implementation for disabling flexi primsis wrong, and that toggling the debug feature on again doesn't bring back flexis until you relog.
[15:48]	: 	oh! please forgive me for going off topic, but there needs to be a way to change animation priorities from scripts -- or maybe UI after there uploaded. I will try to submit this as a feature request
[15:48]	: 	I'd say "don't change" (I thnk the fucntion has it's reason), unless people will hit it accientally (wich is the European sqare bracket thing)
[15:49]	: 	Well, if the flexi debug flax is *supposed* to make them disappear, I agree. But 660 makes a good argument that it should just make them non-flexi.
[15:50]	: 	s/flax/flag/
[15:50]	: 	If 660 means "when flexi are turned off for debug, they aren't draw at all except if an attachment and should be drawn but not flexi", I agree with it ;)
[15:50]	: 	I'll go ahead and import it....it's at least worth a devs time to render an opinion, given there's a patch
[15:51]	: 	I just checked. On my build the function just rendered flexis in Birdies's hair stiff.
[15:51]	: 	It's a pretty small patch, too. It just changes where in the rendering process the flexi debug flag, I think.
[15:51]	: 	s/Birdie/Bridie/
[15:52]	: 	...where in the rendering process the flag is checked, I mean.
[15:52]	: 	oops :-)
[15:52]	: 	is imported
[15:52]	: 	thx Rob
[15:53]	: 	cute cube.
[15:53]	: 	418 is a big one by me, have been discussing it on the list.
[15:54]	: 	I think the rest of the Bugs and Buglets section already has LL issue ids on them
[15:55]	: 	it's probably good to have a list of "ok, so you've imported it...why haven't you done anything" issues, but I'll leave that for anotehr meeting
[15:55]	: 	*hums* :-)
[15:55]	: 	is the next issue that hasn't been imported yet
[15:56]	: 	Can't say much about the platform and scons stuff ... being a Windoozer :-)
[15:56]	: 	Could take some regression tests, but this section seems reasonable
[15:57]	: 	THe problem of this issue is, that nobody except for the submitter has tested SL viewer on big endian Linux box
[15:57]	: 	or seems to be so
[15:58]	Timeless Prototype is Offline 	Timeless Prototype is Offline
[15:58]	: 	Non-issue as long as you don't brag it does work on big-endian ;)
[15:58]	: 	Well, with that one, given't it's Paul who submitted that, I'd say the only question is ... if this include breaks anything for the lil-endian platforms. And I doubt that.
[15:58]	: 	seems like an innocent fix though (just an extra #include)
[15:59]	: 	I'm surprised we wouldn't have noticed this on Mac/PPC, though
[16:00]	: 	(oops, fat fingers)
[16:01]	: 	... ah, I'm sorry but can I jump to 943? I need to leave soon and I have something to say on 943
[16:01]	: 	gotta run
[16:01]	: 	thx all
[16:02]	: 	I'm just going to import all of TBBle's patches, unless anyone sees something we should discuss
[16:02]	: 	I object to 943
[16:02]	: 	(in that section, anyway)
[16:02]	: 	ok, ...let's discuss
[16:02]	: 	I wrote some long comment in JIRA
[16:02]	: 	(sorry if it's misfiled in that secion, I take the blame)
[16:03]	: 	In short, two points: it doesn't look like a bug. THe proposed fix is questionable.
[16:03]	Sindy Tsure w00ts that Rob is still here and she's not too late to bed for 	Sindy Tsure w00ts that Rob is still here and she's not too late to bed for
[16:03]	: 	*beg
[16:04]	: 	Sindy...we're on https://wiki.secondlife.com/wiki/Bug_triage/Agenda
[16:04]	: 	in the Linux issues
[16:04]	Sindy Tsure begs anyway 	Sindy Tsure begs anyway
[16:04]	: 	ok
[16:04]	: 	Alissa: I'll drop a comment asking TBBle to respond
[16:04]	: 	afk
[16:04]	: 	TBBle says lack of en_US.utf8 is a problem, but the code has a safe fallback already. So, I see nothing bad in current code.
[16:05]	: 	Ok.
[16:06]	: 	well, let's go ahead and discuss ....now that I see it
[16:06]	: 	
[16:06]	: 	message template mismatch?
[16:07]	: 	not sure. it looks liek there's two bugs: 1. viewer crashes on malformed packet. 2. server sends malformed packet
[16:07]	: 	#2 is what is filed in . is there a corresponding issue for #1?
[16:07]	Sindy Tsure nods 	Sindy Tsure nods
[16:08]	Sindy Tsure digs.... 	Sindy Tsure digs....
[16:08]	: 	https://jira.secondlife.com/browse/ ?
[16:08]	: 	i think there are several.. that seems to be the latest..
[16:09]	: 	, too
[16:10]	: 	(I'm now leaving... bye.)
[16:10]	: 	re
[16:10]	Sindy Tsure is sorry for not following the agenda.. just had to beg for that one as it's painful for builders..	Sindy Tsure is sorry for not following the agenda.. just had to beg for that one as it's painful for builders..
[16:11]	: 	ok...that's good. I'll import the whole mess then
[16:11]	: 	I need to get going here...I'm already late for my next thing. thanks everyone for showing up!
[16:11]	Sindy Tsure waves 	Sindy Tsure waves
[16:11]	: 	cya!
[16:11]	: 	and thanks Nicholaz for putting together the agenda!
[16:11]	TT Lingiuan applauds 	TT Lingiuan applauds
[16:11]	: 	Thanks, Rob!
[16:11]	: 	take it easy rob
[16:11]	: 	ok, cya then.
[16:11]	: 	Thanks goes to you ;) Have fun !