Program: 107371
Project: 107371
Buggy source:
@Override @DB public boolean deletePool(DeletePoolCmd command) throws InvalidParameterValueException {
  Long id=command.getId();
  boolean deleteFlag=false;
  StoragePoolVO sPool=_storagePoolDao.findById(id);
  if (sPool == null) {
    s_logger.warn("String_Node_Str" + id);
    throw new InvalidParameterValueException("String_Node_Str" + id);
  }
  if (sPool.getPoolType().equals(StoragePoolType.LVM)) {
    s_logger.warn("String_Node_Str" + id);
    throw new InvalidParameterValueException("String_Node_Str" + id);
  }
  List<StoragePoolHostVO> hostPoolRecords=_storagePoolHostDao.listByPoolId(id);
  if (hostPoolRecords.size() == 0) {
    sPool.setUuid(null);
    _storagePoolDao.update(id,sPool);
    _storagePoolDao.remove(id);
    return true;
  }
 else {
    Pair<Long,Long> volumeRecords=_volsDao.getCountAndTotalByPool(id);
    if (volumeRecords.first() > 0) {
      s_logger.warn("String_Node_Str" + sPool.getName() + "String_Node_Str");
      return false;
    }
 else {
      StoragePoolVO lock=_storagePoolDao.acquireInLockTable(sPool.getId());
      try {
        if (lock == null) {
          s_logger.debug("String_Node_Str" + sPool.getId());
          return false;
        }
        for (        StoragePoolHostVO host : hostPoolRecords) {
          DeleteStoragePoolCommand cmd=new DeleteStoragePoolCommand(sPool);
          final Answer answer=_agentMgr.easySend(host.getHostId(),cmd);
          if (answer != null) {
            if (answer.getResult() == true) {
              deleteFlag=true;
              break;
            }
          }
        }
      }
  finally {
        if (lock != null) {
          _storagePoolDao.releaseFromLockTable(lock.getId());
        }
      }
      if (deleteFlag) {
        for (        StoragePoolHostVO host : hostPoolRecords) {
          _storagePoolHostDao.deleteStoragePoolHostDetails(host.getHostId(),host.getPoolId());
        }
        sPool.setUuid(null);
        _storagePoolDao.update(id,sPool);
        _storagePoolDao.remove(id);
        return true;
      }
    }
  }
  return false;
}

Fixed version (ground truth):
@Override @DB public boolean deletePool(DeletePoolCmd command) throws InvalidParameterValueException {
  Long id=command.getId();
  boolean deleteFlag=false;
  StoragePoolVO sPool=_storagePoolDao.findById(id);
  if (sPool == null) {
    s_logger.warn("String_Node_Str" + id);
    throw new InvalidParameterValueException("String_Node_Str" + id);
  }
  if (sPool.getPoolType().equals(StoragePoolType.LVM)) {
    s_logger.warn("String_Node_Str" + id);
    throw new InvalidParameterValueException("String_Node_Str" + id);
  }
  List<StoragePoolHostVO> hostPoolRecords=_storagePoolHostDao.listByPoolId(id);
  if (hostPoolRecords.size() == 0) {
    sPool.setUuid(null);
    _storagePoolDao.update(id,sPool);
    _storagePoolDao.remove(id);
    return true;
  }
 else {
    Pair<Long,Long> volumeRecords=_volsDao.getCountAndTotalByPool(id);
    if (volumeRecords.first() > 0) {
      s_logger.warn("String_Node_Str" + sPool.getName() + "String_Node_Str");
      return false;
    }
 else {
      StoragePoolVO lock=_storagePoolDao.acquireInLockTable(sPool.getId());
      try {
        if (lock == null) {
          if (s_logger.isDebugEnabled())           s_logger.debug("String_Node_Str" + sPool.getId());
          return false;
        }
        for (        StoragePoolHostVO host : hostPoolRecords) {
          DeleteStoragePoolCommand cmd=new DeleteStoragePoolCommand(sPool);
          final Answer answer=_agentMgr.easySend(host.getHostId(),cmd);
          if (answer != null) {
            if (answer.getResult() == true) {
              deleteFlag=true;
              break;
            }
          }
        }
      }
  finally {
        if (lock != null) {
          _storagePoolDao.releaseFromLockTable(lock.getId());
        }
      }
      if (deleteFlag) {
        for (        StoragePoolHostVO host : hostPoolRecords) {
          _storagePoolHostDao.deleteStoragePoolHostDetails(host.getHostId(),host.getPoolId());
        }
        sPool.setUuid(null);
        _storagePoolDao.update(id,sPool);
        _storagePoolDao.remove(id);
        return true;
      }
    }
  }
  return false;
}