Introduce save_strategy training argument
Author: tanmay17061
Pull request: yes

* Introduce save_strategy training argument

* collapse EvaluationStrategy and LoggingStrategy into a single TimeStrategy enum

* modify tests to use modified enum
# What does this PR do?
1. Introduce new `save_strategy` argument to decide on interval between 2 model saves during training.
2. Introduce a unified enum `TimeStrategy` which is used across `evaluation_strategy`, `logging_strategy` and `save_strategy`.

<!--
Congratulations! You've made it this far! You're not quite done yet though.

Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.

Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change.

Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost.
-->

<!-- Remove if not applicable -->

Fixes # (issue)


## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/master/CONTRIBUTING.md#start-contributing-pull-requests),
      Pull Request section?
- [x] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link
      to it if that's the case. [Discussed during PR for logging_strategy.](https://github.com/huggingface/transformers/pull/10267)
- [x] Did you make sure to update the documentation with your changes? Here are the
      [documentation guidelines](https://github.com/huggingface/transformers/tree/master/docs), and
      [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/master/docs#writing-source-documentation).
- [ ] Did you write any new necessary tests?


## Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.

<!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @

 If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**.
 Please tag fewer than 3 people.

Models:

- albert, bert, xlm: @LysandreJik
- blenderbot, bart, marian, pegasus, encoderdecoder,  t5: @patrickvonplaten, @patil-suraj
- longformer, reformer, transfoxl, xlnet: @patrickvonplaten
- fsmt: @stas00
- funnel: @sgugger
- gpt2: @patrickvonplaten, @LysandreJik
- rag: @patrickvonplaten, @lhoestq
- tensorflow: @jplu

Library:

- benchmarks: @patrickvonplaten
- deepspeed: @stas00
- ray/raytune: @richardliaw, @amogkam
- text generation: @patrickvonplaten
- tokenizers: @n1t0, @LysandreJik
- trainer: @sgugger
- pipelines: @LysandreJik

Documentation: @sgugger

HF projects:

- nlp datasets: [different repo](https://github.com/huggingface/nlp)
- rust tokenizers: [different repo](https://github.com/huggingface/tokenizers)

Examples:

- maintained examples (not research project or legacy): @sgugger, @patil-suraj
- research_projects/bert-loses-patience: @JetRunner
- research_projects/distillation: @VictorSanh

 -->
@sgugger

Comments:
Hi @sgugger,  
Got some time to raise the changes we talked about in [my previous PR](https://github.com/huggingface/transformers/pull/10267).  
Do let me know if I missed something.  
Thanks!

Hi @LysandreJik / @sgugger,

Thanks for your inputs! I can think of some better names, _but before that_:  
Is deprecating usage of `EvaluationStrategy` and keeping its definition along with the `TimeStrategy` (or whatever the name would be) in `trainer_utils.py` for the time being a good option? Can also throw a FutureWarning when `EvaluationStrategy` is used.

Yes that would be the preferred option: not use it anymore but still keep it until v5, and each time someone uses it a `FutureWarning` indicating it's deprecated and will be removed in version 5 is thrown.
Let me know if you have other questions!

Hi @sgugger,
Seems like the latest changes are failing a certain `make modified_only_fixup` test.
I'm not entirely sure where this test is failing.
Given that this test is passing on my local machine, this could be due to erratic hard-updation of some test/doc?

> 2021-02-26T19:45:22.6161202Z Checking/fixing src/transformers/__init__.py src/transformers/integrations.py src/transformers/models/__init__.py src/transformers/models/auto/configuration_auto.py src/transformers/models/auto/modeling_auto.py src/transformers/models/auto/modeling_tf_auto.py src/transformers/trainer_callback.py src/transformers/trainer_tf.py src/transformers/trainer_utils.py src/transformers/training_args.py src/transformers/training_args_tf.py src/transformers/utils/dummy_pt_objects.py src/transformers/utils/dummy_tf_objects.py src/transformers/utils/dummy_tokenizers_objects.py src/transformers/utils/notebook.py tests/test_trainer.py tests/test_trainer_callback.py utils/check_repo.py
> 2021-02-26T19:45:24.8027639Z All done! ✨ 🍰 ✨
> 2021-02-26T19:45:24.8028839Z 18 files left unchanged.
> 2021-02-26T19:45:28.4905837Z tests/test_trainer.py:1060:37: F821 undefined name 'EvaluationStrategy'
> 2021-02-26T19:45:28.5127548Z make: *** [modified_only_fixup] Error 1
> 2021-02-26T19:45:28.5129201Z Makefile:7: recipe for target 'modified_only_fixup' failed

Oh and for the failing test, you missed an `EvaluationStrategy` toward the end of `tests/test_trainer.py`, that's why you have the error.

Thanks! Fixed it now.
Although I see some approaches mentioned on other forums, I'm not entirely sure what would be the best approach to print a warning on usage of enum `EvaluationStrategy`.
If not too complex, you can point me towards how to do it.
Otherwise, you can merge this PR :-).

I'm not finding anything easy to do that, so I think we can merge for now and I'll keep looking.