Try to fix training Loss inconsistent after resume from old checkpoint
Author: dumpmemory
Pull request: yes

# What does this PR do?

<!--
Congratulations! You've made it this far! You're not quite done yet though.

Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.

Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change.

Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost.
-->

<!-- Remove if not applicable -->

Fixes #25340 (issue)

From my side, it might relate to the RandomSampler. i just recopy the logic from 4.29.2


## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests),
      Pull Request section?
- [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link
      to it if that's the case.
- [ ] Did you make sure to update the documentation with your changes? Here are the
      [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and
      [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
- [ ] Did you write any new necessary tests?


## Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

<!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @

 If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**.
 Please tag fewer than 3 people.

Models:

- text models: @ArthurZucker and @younesbelkada
- vision models: @amyeroberts
- speech models: @sanchit-gandhi
- graph models: @clefourrier

Library:

- flax: @sanchit-gandhi
- generate: @gante
- pipelines: @Narsil
- tensorflow: @gante and @Rocketknight1
- tokenizers: @ArthurZucker
- trainer: @muellerz and @pacman100

Integrations:

- deepspeed: HF Trainer/Accelerate: @pacman100
- ray/raytune: @richardliaw, @amogkam
- Big Model Inference: @SunMarc
- quantization (bitsandbytes, autogpt): @SunMarc and @younesbelkada

Documentation: @stevhliu and @MKhalusova

HF projects:

- accelerate: [different repo](https://github.com/huggingface/accelerate)
- datasets: [different repo](https://github.com/huggingface/datasets)
- diffusers: [different repo](https://github.com/huggingface/diffusers)
- rust tokenizers: [different repo](https://github.com/huggingface/tokenizers)

Maintained examples (not research project or legacy):

- Flax: @sanchit-gandhi
- PyTorch: See Models above and tag the person corresponding to the modality of the example.
- TensorFlow: @Rocketknight1

 -->


Comments:
The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_25872). All of your documentation changes will be reflected on that endpoint.

cc @muellerzr 

Hi @dumpmemory thanks! Can you do `pip install -e -U .[quality]` and run `make style; make quality` again? This should fix that failing test

> patch-1

I will check it again. 

> Hi @dumpmemory thanks! Can you do `pip install -e -U .[quality]` and run `make style; make quality` again? This should fix that failing test

Done

@dumpmemory what does the following show:

`pip show black isort ruff`

> pip show black isort ruff

```
@dumpmemory ➜ /workspaces/transformers (patch-1) $ pip show black isort ruff
Name: black
Version: 23.7.0
Summary: The uncompromising code formatter.
Home-page: 
Author: 
Author-email: Łukasz Langa <lukasz@langa.pl>
License: MIT
Location: /usr/local/python/3.10.8/lib/python3.10/site-packages
Requires: click, mypy-extensions, packaging, pathspec, platformdirs, tomli
Required-by: 
---
Name: isort
Version: 5.12.0
Summary: A Python utility / library to sort Python imports.
Home-page: https://pycqa.github.io/isort/
Author: Timothy Crosley
Author-email: timothy.crosley@gmail.com
License: MIT
Location: /usr/local/python/3.10.8/lib/python3.10/site-packages
Requires: 
Required-by: 
---
Name: ruff
Version: 0.0.259
Summary: An extremely fast Python linter, written in Rust.
Home-page: https://github.com/charliermarsh/ruff
Author: Charlie Marsh <charlie.r.marsh@gmail.com>
Author-email: Charlie Marsh <charlie.r.marsh@gmail.com>
License: MIT
Location: /usr/local/python/3.10.8/lib/python3.10/site-packages
Requires: 
Required-by: 

```

@amyeroberts feel free to merge if it looks good with you

> @amyeroberts feel free to merge if it looks good with you

I am ok for this pr 😁. Thanks for your support. 

Originally we had thought Accelerate handled this, but it turns out it does not

@amyeroberts , pls help me to check the current version. 

@amyeroberts  can the current version be merged ? is there any thing else i need to change, pls just tell me 

@dumpmemory please have a bit of patience, our team works across multiple timezones and have many other PR's and responsibilities to get to aside this one. We'll get to this when we can, please don't spam :) Thanks

@amyeroberts  How about currently version. I have checked the sampler in final if statement. 

Thanks for your reviews. I think it is ready now. Thanks for your kind helping. 

@dumpmemory There's a current failing test (which I believe is unreleated to your PR). Could you rebase on main to include any recent updates on this branch and trigger a re-run of the CI? 

> @dumpmemory There's a current failing test (which I believe is unreleated to your PR). Could you rebase on main to include any recent updates on this branch and trigger a re-run of the CI?

ok, i will do that