noamaanMulla-03/transformers-issues huggingface dataset:
Create model card for RuPERTA-base-finetuned-pos
Author: mrm8488
Pull request: yes
Labels: name: model card


Comments:
# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/4482?src=pr&el=h1) Report
> Merging [#4482](https://codecov.io/gh/huggingface/transformers/pull/4482?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/efbc1c5a9d96048ab11f8d746fe51107cb91646f&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/huggingface/transformers/pull/4482/graphs/tree.svg?width=650&height=150&src=pr&token=9qOlN6Hb1c)](https://codecov.io/gh/huggingface/transformers/pull/4482?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master    #4482   +/-   ##
=======================================
  Coverage   78.03%   78.03%           
=======================================
  Files         123      123           
  Lines       20477    20477           
=======================================
  Hits        15980    15980           
  Misses       4497     4497           
```


| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/4482?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/transformers/modeling\_tf\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/4482/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `88.50% <0.00%> (-0.17%)` | :arrow_down: |
| [src/transformers/file\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/4482/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `73.85% <0.00%> (+0.41%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/4482?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/4482?src=pr&el=footer). Last update [efbc1c5...82aef0f](https://codecov.io/gh/huggingface/transformers/pull/4482?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
Model card for Tereveni-AI/gpt2-124M-uk-fiction
Author: obsh
Pull request: yes
Labels: name: model card

Create model card for "Tereveni-AI/gpt2-124M-uk-fiction" model

Comments:
by the way, could you add a 

```
---
language: ukrainian
---
```

metadata block on top, for the model to be surfaced in search etc.?

Sure, I’ll add it

On Wed, 20 May 2020 at 18:05, Julien Chaumond <notifications@github.com>
wrote:

> by the way, could you add a
>
> ---
> language: ukrainian
> ---
>
> metadata block on top, for the model to be surfaced in search etc.?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/huggingface/transformers/pull/4470#issuecomment-631533257>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAPCBFE27XTTMKNB2IIQTNTRSPWTPANCNFSM4NFJPXQA>
> .
>
-- 
____________________________________
З повагою, Бушковський Олександр
Fix slow gpu tests lysandre
Author: LysandreJik
Pull request: yes

Fixes three tests of the slow + gpu suite cc @sshleifer 

Comments:
# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/4487?src=pr&el=h1) Report
> Merging [#4487](https://codecov.io/gh/huggingface/transformers/pull/4487?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/6dc52c78d8f1f96ffd9b8f8178e142b7d4a77d14&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/huggingface/transformers/pull/4487/graphs/tree.svg?width=650&height=150&src=pr&token=9qOlN6Hb1c)](https://codecov.io/gh/huggingface/transformers/pull/4487?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master    #4487   +/-   ##
=======================================
  Coverage   78.02%   78.03%           
=======================================
  Files         123      123           
  Lines       20477    20477           
=======================================
+ Hits        15978    15980    +2     
+ Misses       4499     4497    -2     
```


| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/4487?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/transformers/modeling\_tf\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/4487/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `88.66% <0.00%> (+0.16%)` | :arrow_up: |
| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/4487/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `39.76% <0.00%> (+0.23%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/4487?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/4487?src=pr&el=footer). Last update [6dc52c7...2260280](https://codecov.io/gh/huggingface/transformers/pull/4487?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
Make changes to german-bert vocab file more prominent
Author: Timoeller
Pull request: yes
Labels: name: model card

We have been approached by researchers because the expected behavior of their bert-base-german-cased models changed without code modifications. 

- So we wanted to make the changes to the vocab more prominent in the model card 
- and also support a solution where people can easily use the old version through https://huggingface.co/deepset/bert-base-german-cased-oldvocab

Comments:
# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/4488?src=pr&el=h1) Report
> Merging [#4488](https://codecov.io/gh/huggingface/transformers/pull/4488?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/6dc52c78d8f1f96ffd9b8f8178e142b7d4a77d14&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/huggingface/transformers/pull/4488/graphs/tree.svg?width=650&height=150&src=pr&token=9qOlN6Hb1c)](https://codecov.io/gh/huggingface/transformers/pull/4488?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #4488      +/-   ##
==========================================
+ Coverage   78.02%   78.04%   +0.01%     
==========================================
  Files         123      123              
  Lines       20477    20477              
==========================================
+ Hits        15978    15982       +4     
+ Misses       4499     4495       -4     
```


| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/4488?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/4488/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `39.76% <0.00%> (+0.23%)` | :arrow_up: |
| [src/transformers/modeling\_tf\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/4488/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `88.83% <0.00%> (+0.32%)` | :arrow_up: |
| [src/transformers/file\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/4488/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `73.85% <0.00%> (+0.41%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/4488?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/4488?src=pr&el=footer). Last update [6dc52c7...c4a85ea](https://codecov.io/gh/huggingface/transformers/pull/4488?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


Great, thanks for adding this notice
bugfix: pass on tokenizer to pipeline in load_graph_from_args
Author: RensDimmendaal
Pull request: yes

I think I found a small bug in the `load_graph_from_args` function in `convert_graph_to_onnx.py` as it accepts a tokenizer as input but doesn't pass it on to the pipeline inside the function.

Love the library 🤗

Comments:
# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/4489?src=pr&el=h1) Report
> Merging [#4489](https://codecov.io/gh/huggingface/transformers/pull/4489?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/14cb5b35faeda7881341656aacf89d12a8a7e07b&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/huggingface/transformers/pull/4489/graphs/tree.svg?width=650&height=150&src=pr&token=9qOlN6Hb1c)](https://codecov.io/gh/huggingface/transformers/pull/4489?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #4489      +/-   ##
==========================================
- Coverage   78.04%   78.03%   -0.01%     
==========================================
  Files         123      123              
  Lines       20477    20477              
==========================================
- Hits        15981    15980       -1     
- Misses       4496     4497       +1     
```


| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/4489?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/transformers/file\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/4489/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `73.44% <0.00%> (-0.42%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/4489?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/4489?src=pr&el=footer). Last update [14cb5b3...a5ce320](https://codecov.io/gh/huggingface/transformers/pull/4489?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


Indeed ! Thanks for spotting this @RensDimmendaal
LayerNorm not excluded from weight decay in TF
Author: oliverastrand
Pull request: no

# 🐛 Bug

## Information

Model I am using (Bert, XLNet ...):
bert-base-cased

Language I am using the model on (English, Chinese ...):
English

The problem arises when using:
* [X] the official example scripts: (give details below)
* [ ] my own modified scripts: (give details below)

The tasks I am working on is:
* [X] an official GLUE/SQUaD task: (give the name)
* [ ] my own task or dataset: (give details below)

## To reproduce

Steps to reproduce the behavior:

1. Add a print statement to `_do_use_weight_decay` in [AdamWeightDecay](https://github.com/huggingface/transformers/blob/master/src/transformers/optimization_tf.py) to see which parameters are actually excluded:
```python
    def _do_use_weight_decay(self, param_name):
        """Whether to use L2 weight decay for `param_name`."""
        if self.weight_decay_rate == 0:
            return False

        if self._include_in_weight_decay:
            for r in self._include_in_weight_decay:
                if re.search(r, param_name) is not None:
                    return True

        if self._exclude_from_weight_decay:
            for r in self._exclude_from_weight_decay:
                if re.search(r, param_name) is not None:
                    print(f"Found: {param_name}")
                    return False
        return True
```
2. run `python examples/text-classification/run_tf_glue.py --model_name_or_path bert-base-cased --task_name mrpc --output_dir temp --logging_dir temp --do_train --overwrite_output_dir --optimizer_name adamw`. 
3. Observe that no weights related to layer norms are printed. 

<!-- If you have code snippets, error messages, stack traces please provide them here as well.
     Important! Use code tags to correctly format your code. See https://help.github.com/en/github/writing-on-github/creating-and-highlighting-code-blocks#syntax-highlighting
     Do not use screenshots, as they are hard to read and (more importantly) don't allow others to copy-and-paste your code.-->

## Expected behavior

<!-- A clear and concise description of what you would expect to happen. -->
The weights of the layer norms (and the biases) should be printed. 

See for example: https://github.com/google-research/bert/blob/f39e881b169b9d53bea03d2d341b31707a6c052b/optimization.py. 

Based on the fact that no layer norm weights are printed with "layer_norm" simply switching "layer_norm" to "LayerNorm" seems like the easiest change. 

## Environment info
<!-- You can run the command `transformers-cli env` and copy-and-paste its output below.
     Don't forget to fill out the missing fields in that output! -->
     
- `transformers` version: 2.9.0
- Platform: Darwin-19.4.0-x86_64-i386-64bit
- Python version: 3.7.7
- PyTorch version (GPU?): 1.5.0 (False)
- Tensorflow version (GPU?): 2.2.0 (False)
- Using GPU in script?: No
- Using distributed or parallel set-up in script?: No


Comments:
Thanks for the issue dude! Feel free to open a PR if you have a branch that fixed that lying around haha ;-)
❓ Warning : This overload of addcdiv_ is deprecated
Author: astariul
Pull request: no

# ❓ Questions & Help

When running the [official Colab example of GLUE](https://colab.research.google.com/github/huggingface/blog/blob/master/notebooks/trainer/01_text_classification.ipynb), during training I receive a `UserWarning` :

```
/pytorch/torch/csrc/utils/python_arg_parser.cpp:756: UserWarning: This overload of addcdiv_ is deprecated:
	addcdiv_(Number value, Tensor tensor1, Tensor tensor2)
Consider using one of the following signatures instead:
	addcdiv_(Tensor tensor1, Tensor tensor2, *, Number value)
```

---

**Is it expected ?**



Comments:
Not expected, but shouldn't be an issue. Feel free to open a PR swapping args in https://github.com/huggingface/transformers/blob/31eedff5a0fc47d60609089627af6698c21da88d/src/transformers/optimization.py#L165
Add Fine-tune DialoGPT on new datasets notebook
Author: ncoop57
Pull request: yes

Here is a tutorial notebook I created for fine-tuning the DialoGPT on a Spanish conversation dataset. It shows how to prepare a dataset that conforms to the necessary style of the original DialoGPT dataset and how to train it using a GPU provided by Google Colab. Sadly it is not using the newer Trainer that Huggingface provides, but I thought it might be useful for others trying to work with conversational AI so wanted to share.

Thanks for the amazing library and hugs to all of y'all 🤗! 




Comments:
# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/4473?src=pr&el=h1) Report
> Merging [#4473](https://codecov.io/gh/huggingface/transformers/pull/4473?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/48c3a70b4eaedab1dd9ad49990cfaa4d6cb8f6a0&el=desc) will **decrease** coverage by `0.42%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/huggingface/transformers/pull/4473/graphs/tree.svg?width=650&height=150&src=pr&token=9qOlN6Hb1c)](https://codecov.io/gh/huggingface/transformers/pull/4473?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #4473      +/-   ##
==========================================
- Coverage   78.41%   77.98%   -0.43%     
==========================================
  Files         123      123              
  Lines       20432    20432              
==========================================
- Hits        16021    15934      -87     
- Misses       4411     4498      +87     
```


| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/4473?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/transformers/data/processors/squad.py](https://codecov.io/gh/huggingface/transformers/pull/4473/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Byb2Nlc3NvcnMvc3F1YWQucHk=) | `28.66% <0.00%> (-28.03%)` | :arrow_down: |
| [src/transformers/modeling\_tf\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/4473/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `88.66% <0.00%> (+0.16%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/4473?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/4473?src=pr&el=footer). Last update [48c3a70...8518af3](https://codecov.io/gh/huggingface/transformers/pull/4473?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


Cool notebook! And a great complement to the [model card](https://huggingface.co/ncoop57/DiGPTame-medium) 

cc @patrickvonplaten 

Maybe you can use the `Trainer` in a v2 of the notebook =)

And you could use the [nlp](https://github.com/huggingface/nlp) library to share the dataset, cc @thomwolf 

Awesome!
Remove warning of deprecation
Author: astariul
Pull request: yes

Remove warning of deprecated overload of addcdiv_

Fix #4451

Comments:
# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/4477?src=pr&el=h1) Report
> Merging [#4477](https://codecov.io/gh/huggingface/transformers/pull/4477?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/efbc1c5a9d96048ab11f8d746fe51107cb91646f&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `100.00%`.

[![Impacted file tree graph](https://codecov.io/gh/huggingface/transformers/pull/4477/graphs/tree.svg?width=650&height=150&src=pr&token=9qOlN6Hb1c)](https://codecov.io/gh/huggingface/transformers/pull/4477?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #4477      +/-   ##
==========================================
+ Coverage   78.03%   78.12%   +0.08%     
==========================================
  Files         123      123              
  Lines       20477    20477              
==========================================
+ Hits        15980    15997      +17     
+ Misses       4497     4480      -17     
```


| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/4477?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/transformers/optimization.py](https://codecov.io/gh/huggingface/transformers/pull/4477/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9vcHRpbWl6YXRpb24ucHk=) | `96.00% <100.00%> (ø)` | |
| [src/transformers/modeling\_tf\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/4477/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `88.50% <0.00%> (-0.17%)` | :arrow_down: |
| [src/transformers/file\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/4477/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `73.85% <0.00%> (+0.41%)` | :arrow_up: |
| [src/transformers/data/processors/squad.py](https://codecov.io/gh/huggingface/transformers/pull/4477/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Byb2Nlc3NvcnMvc3F1YWQucHk=) | `34.07% <0.00%> (+5.41%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/4477?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/4477?src=pr&el=footer). Last update [efbc1c5...2e2abdc](https://codecov.io/gh/huggingface/transformers/pull/4477?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
How to fine-tune PreTrainedEncoderDecoder on new dataset?
Author: fabrahman
Pull request: no
Labels: name: wontfix

## ❓ Questions & Help

Hi,

Many thanks for your recent work implementing [this paper](https://arxiv.org/pdf/1907.12461.pdf).
I wonder if you have or can provide script and documentation for fine-tuning PreTrainedEncoderDecoder on new dataset?

Many thanks

Comments:
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.


Seconded. Is there a way to fine-tune any seq2seq model in huggingface?

@Josh-Payne You can have a look at https://github.com/huggingface/transformers/blob/9df74b8bc42eedc496f7148b9370728054ca3b6a/src/transformers/modeling_encoder_decoder.py

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Glue test processors and predictions
Author: shoarora
Pull request: yes

Adress #3176 

- Adds a function to load the test dataset for each GLUE task processor.
- Update `run_glue.py` example script to add a `--do_test` flag for producing test set predictions in a `.tsv` file, submittable to the [GLUE scoreboard](https://gluebenchmark.com/).
- Adds a couple extra feature flags to `run_glue.py` that don't need to stay.

Comments:
hm my local isort passes even on a clean env
```
(transformers) shoarora@sho-5:~/transformers ‹glue-test-processors›
$ make style
black --line-length 119 --target-version py35 examples templates tests src utils
All done! ✨ 🍰 ✨
243 files left unchanged.
isort --recursive examples templates tests src utils
(transformers) shoarora@sho-5:~/transformers ‹glue-test-processors›
$ which isort
/home/shoarora/miniconda3/envs/transformers/bin/isort
```

Ultimately, I ran it in the `circleci/python:3.6` docker image to get the correct formatting.  This disagrees with what happens when I style locally in a clean env.  

Hi @shoarora, this is a good addition but in the meantime we updated the run_glue script (and associated utilities) quite a bit in #3800.

Would you like to take a stab at updating this (probably opening a new PR)? The `Trainer`'s predict method accepts non-labelled datasets now so it should be pretty straightforward to hook it. Let us know, otherwise we'll do it down the line.

Would love to see this updated and merged :)

@ZhaofengWu You can check out https://github.com/huggingface/transformers/pull/4463 which we are going to take a look at soon

Thanks!

Closed by #4463