Introduce logging_strategy training argument
Author: tanmay17061
Pull request: yes

Introduce logging_strategy training argument
in TrainingArguments and TFTrainingArguments. (#9838)

# What does this PR do?

<!--
Congratulations! You've made it this far! You're not quite done yet though.

Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.

Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change.

Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost.
-->
1. Introduce a `logging_strategy` argument in TrainingArguments.
2. Define a LoggingStrategy enumeration. This is similar to `EvalStrategy`.

<!-- Remove if not applicable -->

Fixes #9838 


## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/master/CONTRIBUTING.md#start-contributing-pull-requests),
      Pull Request section?
- [x] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link
      to it if that's the case. [Link to issue](https://github.com/huggingface/transformers/issues/9838).
- [x] Did you make sure to update the documentation with your changes? Here are the
      [documentation guidelines](https://github.com/huggingface/transformers/tree/master/docs), and
      [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/master/docs#writing-source-documentation).
- [ ] Did you write any new necessary tests?


## Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.

<!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @

 If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**.
 Please tag fewer than 3 people.

Models:

- albert, bert, xlm: @LysandreJik
- blenderbot, bart, marian, pegasus, encoderdecoder,  t5: @patrickvonplaten, @patil-suraj
- longformer, reformer, transfoxl, xlnet: @patrickvonplaten
- fsmt: @stas00
- funnel: @sgugger
- gpt2: @patrickvonplaten, @LysandreJik
- rag: @patrickvonplaten, @lhoestq
- tensorflow: @jplu

Library:

- benchmarks: @patrickvonplaten
- deepspeed: @stas00
- ray/raytune: @richardliaw, @amogkam
- text generation: @patrickvonplaten
- tokenizers: @n1t0, @LysandreJik
- trainer: @sgugger
- pipelines: @LysandreJik

Documentation: @sgugger

HF projects:

- nlp datasets: [different repo](https://github.com/huggingface/nlp)
- rust tokenizers: [different repo](https://github.com/huggingface/tokenizers)

Examples:

- maintained examples (not research project or legacy): @sgugger, @patil-suraj
- research_projects/bert-loses-patience: @JetRunner
- research_projects/distillation: @VictorSanh

 -->
As changes in trainer: @sgugger

Comments:
Currently WIP.  
Thanks!

Thanks, yes that worked out!  
IMO, defaulting `eval_steps` to `logging_steps` is not a good decision any longer.  
With `logging_strategy` introduced, it seems more intuitive to decouple both. In case user chooses `logging_strategy="epoch"`, `logging_steps` is no longer a valid quantity.  
What is your take on this?

> In case user chooses logging_strategy="epoch", logging_steps is no longer a valid quantity.

It will just be ignored in that case, so there is no weird behavior for the user.

Sure! That makes sense.  
You can review the changes and let me know if any changes required.  
Thanks

Yes, something like `TimeInterval` (or `TimeStrategy`) will be a good generic enum.  
I can work on this generic enum and `saving_strategy` earlier next week most probably. Will raise a PR soon enough.  
For now I've made the amends to introduce `LoggingStrategy.NO`.

Great! We can merge this in the meantime.
Looking forward to your next PR!