fix-qwen2vl-no-position_ids
Author: simonJJJ
Pull request: yes

# What does this PR do?

<!--
Congratulations! You've made it this far! You're not quite done yet though.

Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.

Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change.

Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost.
-->

<!-- Remove if not applicable -->

Fixes # [(issue)](https://github.com/QwenLM/Qwen2-VL/issues/105) [(issue)](https://github.com/QwenLM/Qwen2-VL/issues/112)

We encountered some issues with `position_ids==None` when fine-tuning the qwen2vl model, because the model_inputs do not pass the `position_ids` arg.


## Before submitting
- [] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request),
      Pull Request section?
- [x] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link
      to it if that's the case.
- [ ] Did you make sure to update the documentation with your changes? Here are the
      [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and
      [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
- [ ] Did you write any new necessary tests?


## Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

<!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @

 If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**.
 Please tag fewer than 3 people.

Models:

- text models: @ArthurZucker
- vision models: @amyeroberts, @qubvel
- speech models: @ylacombe, @eustlb
- graph models: @clefourrier

Library:

- flax: @sanchit-gandhi
- generate: @zucchini-nlp (visual-language models) or @gante (all others)
- pipelines: @Rocketknight1
- tensorflow: @gante and @Rocketknight1
- tokenizers: @ArthurZucker
- trainer: @muellerzr and @SunMarc
- chat templates: @Rocketknight1

Integrations:

- deepspeed: HF Trainer/Accelerate: @muellerzr
- ray/raytune: @richardliaw, @amogkam
- Big Model Inference: @SunMarc
- quantization (bitsandbytes, autogpt): @SunMarc

Documentation: @stevhliu

HF projects:

- accelerate: [different repo](https://github.com/huggingface/accelerate)
- datasets: [different repo](https://github.com/huggingface/datasets)
- diffusers: [different repo](https://github.com/huggingface/diffusers)
- rust tokenizers: [different repo](https://github.com/huggingface/tokenizers)

Maintained examples (not research project or legacy):

- Flax: @sanchit-gandhi
- PyTorch: See Models above and tag the person corresponding to the modality of the example.
- TensorFlow: @Rocketknight1

 -->


Comments:
I am trying to finetune Qwen2-VL for Object detection on coco dataset ( https://github.com/zhangfaen/finetune-Qwen2-VL  )

Without this PR, my finetuned model performance is bad.
With this PR (by cherry picking), my finetuned model performance is really good.

Any progress for this PR to be merged?  

Thank you 

> I am trying to finetune Qwen2-VL for Object detection on coco dataset ( https://github.com/zhangfaen/finetune-Qwen2-VL )
> 
> Without this PR, my finetuned model performance is bad. With this PR (by cherry picking), my finetuned model performance is really good.
> 
> Any progress for this PR to be merged?
> 
> Thank you

@zhangfaen Strange, after I modified this code, the fine-tuning performance still did not improve. Is there anything else that needs to be modified?

> > I am trying to finetune Qwen2-VL for Object detection on coco dataset ( https://github.com/zhangfaen/finetune-Qwen2-VL )
> > Without this PR, my finetuned model performance is bad. With this PR (by cherry picking), my finetuned model performance is really good.
> > Any progress for this PR to be merged?
> > Thank you
> 
> @zhangfaen Strange, after I modified this code, the fine-tuning performance still did not improve. Is there anything else that needs to be modified?

for what task and against what dataset are you finetuning qwen2-vl ?

hi @ArthurZucker, would u mind taking a look at merging this PR? The community is waiting for it.

> hi @ArthurZucker, would u mind taking a look at merging this PR? The community is waiting for it.

+1 @ArthurZucker 

> Yep sorry I approved I don't know why it was lost in tracks!

Hi there, when I used `pip install transformers`, I installed version 4.46.2, which still does not include the updates mentioned here https://github.com/huggingface/transformers/blob/main/src/transformers/models/qwen2_vl/modeling_qwen2_vl.py#L1723.