Re: Add Japanese RoBERTa Model
Author: butsugiri
Pull request: yes

I have re-created PR as CI does not seem to trigger as expected.

The original PR is #13065 


Comments:
@LysandreJik I hope that CI runs this time.
I will soon add missing documents 😄 

Hey @butsugiri! For some reason the tests still didn't run, but I could push a branch and open a PR from my personal fork with your commits here: https://github.com/huggingface/transformers/pull/14233

This triggered the tests and ran them on your latest commit which now shows here (yay!).

@LysandreJik Thank you for your help! I close this PR.

...or should I keep this open? Sorry that I am confused 😟 

I have just added documents and made few modification to address CI errors.

@butsugiri, yes, please keep this open! I'll make sure to force the CI runs on it :)

Hey @butsugiri, it seems that most of the issues in the tests could be solved with a rebase on `master`. Could you do it? I'm happy to do it too, but I'll need you to invite me to your repository so that I have commit rights.

Hi, @LysandreJik . Thanks again for your message.
I have invited you to our fork repository with `write` access.
Since I am unfamiliar with rebase command, could you do it, please? Thanks!

Thank you for the invitation! I have just rebased on `master`, and forced pushed your branch. Let's see if the tests succeed!

There are a few tests failing, do you manage to see the output of these tests when clicking on "Details"? I believe it's mostly due to the `fugashi` missing installation. Would you like me to take a look at that issue as well, or would you like to take a stab at it? :)

Thanks for rebasing and pushing! I confirmed that I can see the failed CIs from "Details".
Regarding the missing `fugashi` installation: do you have any ideas for solving this issue?
If I understood correctly, it seems that similar JapaneseBERT Tokenizer is ignoring the test when `fugashi`  is unavailable. 
https://github.com/huggingface/transformers/blob/master/tests/test_tokenization_bert_japanese.py#L124-L127
However, I suppose that there may be a better way 🤔 


That's the favored way, and we can install fugashi in a run such as this one: https://github.com/huggingface/transformers/blob/master/.circleci/config.yml#L516

This fits perfectly, as this too is a custom tokenizer :)

I see that there is already a CI config for custom tokenizer 😄 
According to your link, pip install should be running with `ja` option, which includes the installation of `fugashi` https://github.com/huggingface/transformers/blob/master/setup.py#L234
Would you please take a look at fugashi installation failure?




Let's see, I'm re-running the CI

Tried to fix it here, will see: https://github.com/huggingface/transformers/pull/14233

`do_zenkaku=True` seems harmful when it is used with `[MASK]` or `<mask>` on `FillMaskPipeline`. How do you think @butsugiri ?

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the [contributing guidelines](https://github.com/huggingface/transformers/blob/master/CONTRIBUTING.md) are likely to be ignored.