Fix the StarCoder agent max_new_tokens input validation error
Author: dashapetr
Pull request: yes
Labels: name: Feature request

 Committer: Darya Petrashka <dashacheb15@gmail.com>

# What does this PR do?

<!--
Congratulations! You've made it this far! You're not quite done yet though.

Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.

Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change.

Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost.
-->

<!-- Remove if not applicable -->

Fixes #28523


## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests),
      Pull Request section?
- [x] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link
      to it if that's the case.
link: https://github.com/huggingface/transformers/issues/28523
- [ ] Did you make sure to update the documentation with your changes? Here are the
      [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and
      [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
- [ ] Did you write any new necessary tests?


## Who can review?
@ArthurZucker and @younesbelkada

<!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @

 If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**.
 Please tag fewer than 3 people.

Models:

- text models: @ArthurZucker and @younesbelkada
- vision models: @amyeroberts
- speech models: @sanchit-gandhi
- graph models: @clefourrier

Library:

- flax: @sanchit-gandhi
- generate: @gante
- pipelines: @Narsil
- tensorflow: @gante and @Rocketknight1
- tokenizers: @ArthurZucker
- trainer: @muellerzr and @pacman100

Integrations:

- deepspeed: HF Trainer/Accelerate: @pacman100
- ray/raytune: @richardliaw, @amogkam
- Big Model Inference: @SunMarc
- quantization (bitsandbytes, autogpt): @SunMarc and @younesbelkada

Documentation: @stevhliu and @MKhalusova

HF projects:

- accelerate: [different repo](https://github.com/huggingface/accelerate)
- datasets: [different repo](https://github.com/huggingface/datasets)
- diffusers: [different repo](https://github.com/huggingface/diffusers)
- rust tokenizers: [different repo](https://github.com/huggingface/tokenizers)

Maintained examples (not research project or legacy):

- Flax: @sanchit-gandhi
- PyTorch: See Models above and tag the person corresponding to the modality of the example.
- TensorFlow: @Rocketknight1

 -->


Comments:
> Thanks! Won't this default to `max_new_tokens=20` that is set in generate if the arg is not passed?

I am not sure about this.

I didn't manage to find what exact place the limitation of  `max_new_token `<= 192 comes from. If we look at the tool level, each separate tool (model) has its own limitation of `max_new_tokens`.  If we refer to [API's documentation](https://huggingface.co/docs/api-inference/detailed_parameters#detailed-parameters), there is no default value for `max_new_tokens`.

One more possible solution I see here is to set `max_new_tokens`=192 so the validation error won't appear.

So the HFAgent and the Local agent who both use huggingface tools will be limited by the `max_new_tokens` that you give them / by the default `max_new_token` / `max_length` of the model on the hub. I think the goal of the agents where to have simple APIs so 200 tokens default seemed alright for me. Otherwise it can never stop for a lot of model. 
I'll add a feature request for setting this but think we should keep it that way for now!

> I think the goal of the agents where to have simple APIs so 200 tokens default seemed alright for me. Otherwise it can never stop for a lot of model.

Agree with this. But the issue is still here: 

![image](https://github.com/huggingface/transformers/assets/54349415/83eba330-4913-4e10-b5fb-5d3fdcb7ed31)

I believe it is because the HFAgent limits `max_new_tokens` to **200**, but the `starcoder` API needs **192** tokens or less.


Would you suggest adding a controllable argument? 

Issue is not resolved yet.