Fix CI with change of name of nlp
Author: sgugger
Pull request: yes

Fixes #7055 (because yes, I can see the future)

Comments:
# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/7054?src=pr&el=h1) Report
> Merging [#7054](https://codecov.io/gh/huggingface/transformers/pull/7054?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/d6c08b07a087e83915b4b3156bbf464cebc7b9b5?el=desc) will **increase** coverage by `2.11%`.
> The diff coverage is `100.00%`.

[![Impacted file tree graph](https://codecov.io/gh/huggingface/transformers/pull/7054/graphs/tree.svg?width=650&height=150&src=pr&token=9qOlN6Hb1c)](https://codecov.io/gh/huggingface/transformers/pull/7054?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #7054      +/-   ##
==========================================
+ Coverage   78.74%   80.85%   +2.11%     
==========================================
  Files         168      168              
  Lines       32172    32172              
==========================================
+ Hits        25335    26014     +679     
+ Misses       6837     6158     -679     
```


| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/7054?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/transformers/\_\_init\_\_.py](https://codecov.io/gh/huggingface/transformers/pull/7054/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9fX2luaXRfXy5weQ==) | `99.33% <ø> (ø)` | |
| [src/transformers/tokenization\_xlm.py](https://codecov.io/gh/huggingface/transformers/pull/7054/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25feGxtLnB5) | `82.93% <ø> (ø)` | |
| [src/transformers/file\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/7054/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `82.66% <100.00%> (+0.25%)` | :arrow_up: |
| [src/transformers/trainer.py](https://codecov.io/gh/huggingface/transformers/pull/7054/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyLnB5) | `54.68% <100.00%> (ø)` | |
| [src/transformers/modeling\_tf\_funnel.py](https://codecov.io/gh/huggingface/transformers/pull/7054/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mdW5uZWwucHk=) | `18.53% <0.00%> (-75.51%)` | :arrow_down: |
| [src/transformers/modeling\_tf\_flaubert.py](https://codecov.io/gh/huggingface/transformers/pull/7054/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9mbGF1YmVydC5weQ==) | `24.53% <0.00%> (-63.81%)` | :arrow_down: |
| [src/transformers/modeling\_marian.py](https://codecov.io/gh/huggingface/transformers/pull/7054/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19tYXJpYW4ucHk=) | `60.00% <0.00%> (-30.00%)` | :arrow_down: |
| [src/transformers/activations.py](https://codecov.io/gh/huggingface/transformers/pull/7054/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9hY3RpdmF0aW9ucy5weQ==) | `85.00% <0.00%> (-5.00%)` | :arrow_down: |
| [src/transformers/configuration\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/7054/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9jb25maWd1cmF0aW9uX2JhcnQucHk=) | `90.00% <0.00%> (-4.00%)` | :arrow_down: |
| [src/transformers/modeling\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/7054/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19iYXJ0LnB5) | `93.77% <0.00%> (-0.68%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/huggingface/transformers/pull/7054/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/7054?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/7054?src=pr&el=footer). Last update [df4594a...f8b9682](https://codecov.io/gh/huggingface/transformers/pull/7054?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


Merging to make the CI green but happy to address any comment in a follow-up PR.

```
_______________________________________________________ ERROR collecting tests/test_trainer.py _______________________________________________________
ImportError while importing test module '/mnt/nvme1/code/huggingface/transformers-master/tests/test_trainer.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/home/stas/anaconda3/envs/main-37/lib/python3.7/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_trainer.py:3: in <module>
    import datasets
E   ModuleNotFoundError: No module named 'datasets'
```

and after `pip install datasets` (needed in `setup.py`), the failure is still the same as in https://github.com/huggingface/transformers/issues/7055

I think you need an install from source.


not sure what you mean? install from source `datasets`?

I did:

```
git pull
pip install -e .[dev]
```
in transformers

It's not in the depencies of transformers and requires a separate install from source for now. It does work on the CI and my machine:
```
git clone https://github.com/huggingface/datasets
cd datasets
pip install -e .
```

I did what you suggested, same failures.

Are you sure you are in the same env?

nlp was never in `setup.py`. It is an additional dep required for the full test suite as a source install for now, will become a dep when it's stable enough. I'll add that to the CONTRIBUTING but trying to understand why it fails for you before.

I have 2 gpus, you probably don't?

Indeed, if I run:

```CUDA_VISIBLE_DEVICES="" pytest tests/test_trainer.py```

it works.

Yup, it's multi-gpu that is the problem. It works if I do `CUDA_VISIBLE_DEVICES="0" pytest tests/test_trainer.py`

Mmmm, why would the multi-gpu not see a new module. That's weird.

I'm not sure you have looked at the errors https://github.com/huggingface/transformers/issues/7055 - they are of numeric mismatch nature. Have a look?

`12 != 24.0` looks like 1 vs 2 gpu issue.

let's move back into #7055 and continue there.

Oh this is a different error, not a missing model. Looks like those tests need a decorator to run on the CPU only.

> nlp was never in setup.py. It is an additional dep required for the full test suite as a source install for now, will become a dep when it's stable enough. I'll add that to the CONTRIBUTING but trying to understand why it fails for you before.

`datasets` needs to be in requirements for `dev` - otherwise test suite fails.

Yes, like I said you need a separate source install of it. You can't have a source install from dev that is properly up to date AFAIK.

Documented this in #7058