Clean up staging tmp checkpoint directory
Author: woshiyyya
Pull request: yes

# What does this PR do?

In PR #28364 , it changed the checkpoint folder renaming logic, which makes only local_rank_0 workers or global_rank_0 worker to rename the checkpoint dir from `tmp-checkpoint-*` to `checkpoint-*`. It will be a noop on other ranks.

When we have multiple nodes, and if you save on global rank 0 only, the tmp checkpoint dir on other nodes might not get cleaned up on. This PR checks and deletes those tmp directories.

<!--
Congratulations! You've made it this far! You're not quite done yet though.

Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.

Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change.

Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost.
-->

<!-- Remove if not applicable -->

Fixes # (issue)


## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests),
      Pull Request section?
- [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link
      to it if that's the case.
- [ ] Did you make sure to update the documentation with your changes? Here are the
      [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and
      [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
- [ ] Did you write any new necessary tests?


## Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

<!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @

 If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**.
 Please tag fewer than 3 people.

Models:

- text models: @ArthurZucker and @younesbelkada
- vision models: @amyeroberts
- speech models: @sanchit-gandhi
- graph models: @clefourrier

Library:

- flax: @sanchit-gandhi
- generate: @gante
- pipelines: @Narsil
- tensorflow: @gante and @Rocketknight1
- tokenizers: @ArthurZucker
- trainer: @muellerzr and @pacman100

Integrations:

- deepspeed: HF Trainer/Accelerate: @pacman100
- ray/raytune: @richardliaw, @amogkam
- Big Model Inference: @SunMarc
- quantization (bitsandbytes, autogpt): @SunMarc and @younesbelkada

Documentation: @stevhliu and @MKhalusova

HF projects:

- accelerate: [different repo](https://github.com/huggingface/accelerate)
- datasets: [different repo](https://github.com/huggingface/datasets)
- diffusers: [different repo](https://github.com/huggingface/diffusers)
- rust tokenizers: [different repo](https://github.com/huggingface/tokenizers)

Maintained examples (not research project or legacy):

- Flax: @sanchit-gandhi
- PyTorch: See Models above and tag the person corresponding to the modality of the example.
- TensorFlow: @Rocketknight1

 -->


Comments:
cc  @pacman100 @muellerzr 

cc @amyeroberts 

@pacman100 Is pinging me for review here a signal that you approve of these changes and it's ready for final review? 

Any updates on this?

@pacman100 Requested review from you to confirm this fix is in line with expected trainer behaviour. Once you've approved I can do the final maintainer review 

The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28848). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Does this pr work when multi node using deferent storage system?  If multi nodes use the same file system, this pr seems useless and involves new problem: non global rank0 may rmtree the tmp-checkpoint dir before global rank0 rename

I am getting an error because of this PR. all the local zero processes try to delete the same dir that is on shared file system between the nodes

I'm running into the same issue as @sinamoeini. Kindly help to review @woshiyyya.

Got it. It could be a problem when using a shared file system. 

Let's [revert this PR](https://github.com/huggingface/transformers/pull/29336) and keep the staging checkpoint dir?  cc @amyeroberts @pacman100 

so I replaced [this line](https://github.com/huggingface/transformers/blob/v4.38.0/src/transformers/trainer.py#L2552) with 

```
elif self.is_local_process_zero() and self.args.save_on_each_node:
```
and it worked. Not sure if it will cause issue with other setups.

Downgrading the transformers version to 4.37.0 avoids the problem

This has been completely reverted by now (staging as a whole) the latest transformers install should fix it