change sequence_bias type of SequenceBiasLogitsProcessor to list, add…
Author: VladOS95-cyber
Pull request: yes

# What does this PR do?
Introduce new sequence_bias parameter type as List[List[List[int], float]] for SequenceBiasLogitsProcessor and config tests for all logits processors
<!--
Congratulations! You've made it this far! You're not quite done yet though.

Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.

Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change.

Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost.
-->

<!-- Remove if not applicable -->

Fixes # (issue)


## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request),
      Pull Request section?
- [x] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link
      to it if that's the case. Link: https://github.com/huggingface/transformers/issues/32416
- [x] Did you make sure to update the documentation with your changes? Here are the
      [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and
      [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
- [x] Did you write any new necessary tests?


## Who can review?
@gante @zucchini-nlp @ArthurZucker 
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

<!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @

 If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**.
 Please tag fewer than 3 people.

Models:

- text models: @ArthurZucker
- vision models: @amyeroberts
- speech models: @sanchit-gandhi
- graph models: @clefourrier

Library:

- flax: @sanchit-gandhi
- generate: @zucchini-nlp (visual-language models) or @gante (all others)
- pipelines: @Narsil
- tensorflow: @gante and @Rocketknight1
- tokenizers: @ArthurZucker
- trainer: @muellerzr and @SunMarc

Integrations:

- deepspeed: HF Trainer/Accelerate: @muellerzr
- ray/raytune: @richardliaw, @amogkam
- Big Model Inference: @SunMarc
- quantization (bitsandbytes, autogpt): @SunMarc

Documentation: @stevhliu

HF projects:

- accelerate: [different repo](https://github.com/huggingface/accelerate)
- datasets: [different repo](https://github.com/huggingface/datasets)
- diffusers: [different repo](https://github.com/huggingface/diffusers)
- rust tokenizers: [different repo](https://github.com/huggingface/tokenizers)

Maintained examples (not research project or legacy):

- Flax: @sanchit-gandhi
- PyTorch: See Models above and tag the person corresponding to the modality of the example.
- TensorFlow: @Rocketknight1

 -->


Comments:
Hi @gante, please, review this PR. I completely messed with previous one https://github.com/huggingface/transformers/pull/33362. This is cleaner, I resolved all your comments from the last time and included config tests for almost all processors

Just add @zucchini-nlp and @ArthurZucker in case if @gante is busy

@zucchini-nlp Hi! Do I have to fix failed tests somehow? Because it looks like it is not related to my changes at all

Failing tests are okey, they are also failing in other PRs. You can try rebasing main to see if they are already fixed, the last time it was still broken in one of my PRs 

> Failing tests are okey, they are also failing in other PRs. You can try rebasing main to see if they are already fixed, the last time it was still broken in one of my PRs

Ok, got it, thanks a lot!

Hi @gante! Just a kindly reminder ping in order to not loose this PR!

@LysandreJik some context :D

this PR: 
1. Changes the type of the `sequence_bias`. The previous type was not json serializable. We keep BC, but all documentation points towards the serializable type (so that users don't hit the limitation)
2. @VladOS95-cyber kindly added tests for serialization of logits processors arguments in the generation config 💛 

> Thank you for iterating @VladOS95-cyber -- and especially for adding the new tests. I really appreciate the work 🙏
> 
> IMO the PR could be merged as is. I've added a few improvement suggestions for long-term maintenance.
> 
> Regarding red CI -- try rebasing the PR. If it's still red after that, I will dive to figure out what's wrong :)

Hi @gante, I just pushed changes based on your comments and did rebase, still the same test issues

@VladOS95-cyber I've checked internally -- it is a known issue and it is being fixed :) 

By the time @LysandreJik approves the PR it should be fixed

> That's a very impressive additional test suite!
> 
> The change looks good to me, thanks for updating the docs alongside it.

Hi @LysandreJik sure, no problem! Should I do smth else, like rebase to re-run failed tests or anything?

Hey @VladOS95-cyber -- rebasing should get us rid of the red CI!

> Hey @VladOS95-cyber -- rebasing should get us rid of the red CI!

Hey @gante, ok, no worries, I'll do that

green CI, perfect!

@VladOS95-cyber thank you for iterating with us and, more importantly, for making `transformers` better for everyone 💛 

> green CI, perfect!
> 
> @VladOS95-cyber thank you for iterating with us and, more importantly, for making `transformers` better for everyone 💛

@gante Thank you too! Let's keep working on it!