noamaanMulla-03/transformers-issues huggingface dataset:
examples/seq2seq/run_eval.py fixes and docs
Author: sshleifer
Pull request: yes


Comments:
# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5322?src=pr&el=h1) Report
> Merging [#5322](https://codecov.io/gh/huggingface/transformers/pull/5322?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/5543b30aa6b52da3c8f7d9e525b0edc26226d717&el=desc) will **increase** coverage by `0.45%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/huggingface/transformers/pull/5322/graphs/tree.svg?width=650&height=150&src=pr&token=9qOlN6Hb1c)](https://codecov.io/gh/huggingface/transformers/pull/5322?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #5322      +/-   ##
==========================================
+ Coverage   77.42%   77.88%   +0.45%     
==========================================
  Files         138      138              
  Lines       24284    24284              
==========================================
+ Hits        18803    18914     +111     
+ Misses       5481     5370     -111     
```


| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5322?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/transformers/modeling\_tf\_distilbert.py](https://codecov.io/gh/huggingface/transformers/pull/5322/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9kaXN0aWxiZXJ0LnB5) | `66.25% <0.00%> (-32.52%)` | :arrow_down: |
| [src/transformers/modeling\_tf\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5322/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `86.74% <0.00%> (+0.58%)` | :arrow_up: |
| [src/transformers/tokenization\_albert.py](https://codecov.io/gh/huggingface/transformers/pull/5322/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90b2tlbml6YXRpb25fYWxiZXJ0LnB5) | `87.50% <0.00%> (+58.65%)` | :arrow_up: |
| [src/transformers/modeling\_tf\_electra.py](https://codecov.io/gh/huggingface/transformers/pull/5322/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl9lbGVjdHJhLnB5) | `95.38% <0.00%> (+68.46%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5322?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5322?src=pr&el=footer). Last update [5543b30...eae8c2d](https://codecov.io/gh/huggingface/transformers/pull/5322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
encode_for_summarization function did actually add CLS and SEP to separate sentences
Author: xdwang0726
Pull request: no
Labels: name: wontfix

https://github.com/huggingface/transformers/blob/d32585a304107cb9f42ccb0e1278405aa3eb6c9c/examples/summarization/bertabs/utils_summarization.py#L130

Hi, 

Could you please take a look at this part of the codes? I think this part might not act the function to separate the sentences. The function doesn't actually add CLS and SEP to sentences. Thank you in advance for your help! 

Comments:
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
How to reduce random summary generation of BART Summarization models?
Author: aliasneo1
Pull request: no
Labels: name: Discussion

name: wontfix

Currently BART model trained on CNN dataset is generating summaries which consist of new nouns which are not present in the input text.
How to control the randomness of these summaries. Is there any parameter like temperature in GPT-2 model which can control the degree to which the model can go off-topic?

  

Comments:
BART is used as a model for abstractive summarization so it can use different words than those used in the original text. But it should not go *off-topic*. You could use an extractive summarization model instead which does not generate new nouns. Also you might be interested in the methods from [*Controlling the Amount of Verbatim Copying in Abstractive Summarization*](https://arxiv.org/pdf/1911.10390.pdf) to control the degree of change in the summaries.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
[Wait to merge] [Bart] Rename lm_labels argument to masked_lm_labels
Author: dougian
Pull request: yes

While the docstring correctly lists masked_lm_labels, forward
was expecting lm_labels. Renaming to match BERT and the rest of
the MLM-based models



Comments:
Could you make sure the kwarg in `examples/summarization/bart/run_bart_sum.py` is correct? Thanks!

# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/3500?src=pr&el=h1) Report
> Merging [#3500](https://codecov.io/gh/huggingface/transformers/pull/3500?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/601ac5b1dc1438f00d09696588f2deb0f045ae3b&el=desc) will **increase** coverage by `0.50%`.
> The diff coverage is `100.00%`.

[![Impacted file tree graph](https://codecov.io/gh/huggingface/transformers/pull/3500/graphs/tree.svg?width=650&height=150&src=pr&token=9qOlN6Hb1c)](https://codecov.io/gh/huggingface/transformers/pull/3500?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #3500      +/-   ##
==========================================
+ Coverage   77.79%   78.30%   +0.50%     
==========================================
  Files         100      100              
  Lines       17051    17051              
==========================================
+ Hits        13265    13351      +86     
+ Misses       3786     3700      -86     
```


| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/3500?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/transformers/modeling\_bart.py](https://codecov.io/gh/huggingface/transformers/pull/3500/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19iYXJ0LnB5) | `97.58% <100.00%> (ø)` | |
| [src/transformers/modeling\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/3500/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ191dGlscy5weQ==) | `91.94% <0.00%> (+0.13%)` | :arrow_up: |
| [src/transformers/data/processors/squad.py](https://codecov.io/gh/huggingface/transformers/pull/3500/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9kYXRhL3Byb2Nlc3NvcnMvc3F1YWQucHk=) | `56.49% <0.00%> (+27.59%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/3500?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/3500?src=pr&el=footer). Last update [601ac5b...70f9258](https://codecov.io/gh/huggingface/transformers/pull/3500?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


> Could you make sure the kwarg in `examples/summarization/bart/run_bart_sum.py` is correct? Thanks!

Sure, updated all occurrences on that file

@dougian : we are going to merge/adopt this after a few other PRs are merged in order to coordinate the signature with T5's signature. Thanks for your contribution!


Fixed on master by other PRs, closing. Thanks!
T5ForConditionalGeneration fp16 nan loss
Author: xwhan
Pull request: no

# 🐛 Bug

## Information

Model I am using (Bert, XLNet ...):

Language I am using the model on (English, Chinese ...):

The problem arises when using:
* [ ] the official example scripts: (give details below)
* [x] my own modified scripts: (give details below)

The tasks I am working on is:
* [ ] an official GLUE/SQUaD task: (give the name)
* [x] my own task or dataset: (give details below)

## To reproduce

Steps to reproduce the behavior:

(Pdb) net_inputs["attention_mask"]
tensor([[1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0],
        [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1]], device='cuda:0')
(Pdb) net_inputs["lm_labels"]
tensor([[    3,  1489,    89,  -100,  -100,  -100],
        [ 5441,  1511,    13,     3, 10314,   152]], device='cuda:0')
(Pdb) net_inputs["lm_labels"]
tensor([[    3,  1489,    89,  -100,  -100,  -100],
        [ 5441,  1511,    13,     3, 10314,   152]], device='cuda:0')
(Pdb)

1.  model = T5ForConditionalGeneration.from_pretrained("t5-large")
2. outputs = model(input_ids=net_inputs["input_ids"], attention_mask=net_inputs["attention_mask"], lm_labels=net_inputs["lm_labels"])
3. loss, lm_logits = outputs[0], outputs[1]; print(loss)


<!-- If you have code snippets, error messages, stack traces please provide them here as well.
     Important! Use code tags to correctly format your code. See https://help.github.com/en/github/writing-on-github/creating-and-highlighting-code-blocks#syntax-highlighting
     Do not use screenshots, as they are hard to read and (more importantly) don't allow others to copy-and-paste your code.-->

## Expected behavior

<!-- A clear and concise description of what you would expect to happen. -->
Seems like a masking issue. 

## Environment info
<!-- You can run the command `transformers-cli env` and copy-and-paste its output below.
     Don't forget to fill out the missing fields in that output! -->
     
- `transformers` version: 2.11.0
- Platform: V100
- Python version: 3.6.10
- PyTorch version (GPU?): 1.5.0
- Tensorflow version (GPU?):N/A
- Using GPU in script?: yes
- Using distributed or parallel set-up in script?: parallel


Comments:
See #4586.
CTRL generates French text when I want English texts
Author: AdaUchendu
Pull request: no
Labels: name: wontfix

name: Ex: Generation

# ❓ Questions & Help

<!-- The GitHub issue tracker is primarly intended for bugs, feature requests,
     new models and benchmarks, and migration questions. For all other questions,
     we direct you to Stack Overflow (SO) where a whole community of PyTorch and
     Tensorflow enthusiast can help you out. Make sure to tag your question with the
     right deep learning framework as well as the huggingface-transformers tag: 
     https://stackoverflow.com/questions/tagged/huggingface-transformers 
     
     If your question wasn't answered after a period of time on Stack Overflow, you
     can always open a question on GitHub. You should then link to the SO question 
     that you posted.
     -->

## Details
<!-- Description of your issue -->
CTRL generates French texts when I want English texts.
I run this command: **python examples/run_generation.py  --model_type ctrl --model_name_or_path ctrl --prompt "Looking well today" --length 500 --temperature 0.8 --repetition 1.2**

What do I need to add or change to generate English texts only?


<!-- You should first ask your question on SO, and only if
     you didn't get an answer ask it here on GitHub. -->


Comments:
CTRL uses control codes, as is mentioned in our documentation, with examples on the [original repository](https://github.com/salesforce/ctrl#generations). Have you tried using these control codes?

How do I specify which control code I want to use? Do I have to do that in the command line and if yes, how?  This is the Control code I want to use 16360 (i.e. politics). 

Thank you 

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Predefined tasks in T5
Author: vishal-burman
Pull request: no

```
  "task_specific_params": {
    "summarization": {
      "early_stopping": true,
      "length_penalty": 2.0,
      "max_length": 200,
      "min_length": 30,
      "no_repeat_ngram_size": 3,
      "num_beams": 4,
      "prefix": "summarize: "
    },
    "translation_en_to_de": {
      "early_stopping": true,
      "max_length": 300,
      "num_beams": 4,
      "prefix": "translate English to German: "
    },
    "translation_en_to_fr": {
      "early_stopping": true,
      "max_length": 300,
      "num_beams": 4,
      "prefix": "translate English to French: "
    },
    "translation_en_to_ro": {
      "early_stopping": true,
      "max_length": 300,
      "num_beams": 4,
      "prefix": "translate English to Romanian: "
    }
  },

```
The config file generated while saving a T5 model mentions the above-predefined tasks which can be done by just prepending the inputs with appropriate prefixes. I wanted to know if there is a list that shows any other predefined tasks which can be performed by T5.

Comments:
You can take a look the paper to find out other tasks. AFAIK it includes GLUE tasks, and SQuAD QA as well.

https://arxiv.org/pdf/1910.10683

On page 45 the examples for many tasks are starting and ending on page 52

Thanks for the help. I will refer the paper.
Added support for XLNet language modelling training in examples
Author: shngt
Pull request: yes

Updated src/transformers/data/data_collator.py with a new XLNet-specific collator that applies masking and generates revelant tensors (input_ids, perm_mask, target_mask, labels) as per https://github.com/zihangdai/xlnet/blob/master/data_utils.py. Also added relevant calls and imports in examples/language-modeling/run_language_modeling.py. Relevant issues #4739 #2008 

Comments:
CircleCI says:
examples/language-modeling/run_language_modeling.py:29: in <module>
    from transformers import (
E   ImportError: cannot import name 'DataCollatorForXLNetLanguageModeling'

How can I fix this?

`DataCollatorForXLNetLanguageModeling` needs to be imported into `src/transformers/__init__.py`  to  be imported `from transformers`
More model cards
Author: sgugger
Pull request: yes
Labels: name: model card


Comments:
# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5324?src=pr&el=h1) Report
> Merging [#5324](https://codecov.io/gh/huggingface/transformers/pull/5324?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/5543b30aa6b52da3c8f7d9e525b0edc26226d717&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/huggingface/transformers/pull/5324/graphs/tree.svg?width=650&height=150&src=pr&token=9qOlN6Hb1c)](https://codecov.io/gh/huggingface/transformers/pull/5324?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #5324      +/-   ##
==========================================
+ Coverage   77.42%   77.48%   +0.05%     
==========================================
  Files         138      138              
  Lines       24284    24284              
==========================================
+ Hits        18803    18816      +13     
+ Misses       5481     5468      -13     
```


| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5324?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/transformers/modeling\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5324/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ191dGlscy5weQ==) | `91.26% <0.00%> (+0.12%)` | :arrow_up: |
| [src/transformers/file\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5324/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `79.93% <0.00%> (+0.66%)` | :arrow_up: |
| [src/transformers/modeling\_tf\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5324/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `87.62% <0.00%> (+1.47%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5324?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5324?src=pr&el=footer). Last update [5543b30...711a3d4](https://codecov.io/gh/huggingface/transformers/pull/5324?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


Thanks for fixing my typos :-)
More model cards
Author: sgugger
Pull request: yes
Labels: name: model card


Comments:
# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5307?src=pr&el=h1) Report
> Merging [#5307](https://codecov.io/gh/huggingface/transformers/pull/5307?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/88d7f96e33c3f3e541bcdd913f2ff1e50aa18c1b&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/huggingface/transformers/pull/5307/graphs/tree.svg?width=650&height=150&src=pr&token=9qOlN6Hb1c)](https://codecov.io/gh/huggingface/transformers/pull/5307?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master    #5307   +/-   ##
=======================================
  Coverage   79.30%   79.30%           
=======================================
  Files         138      138           
  Lines       24283    24283           
=======================================
+ Hits        19257    19258    +1     
+ Misses       5026     5025    -1     
```


| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5307?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/transformers/file\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5307/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9maWxlX3V0aWxzLnB5) | `79.59% <0.00%> (+0.33%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5307?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5307?src=pr&el=footer). Last update [88d7f96...0bf35c5](https://codecov.io/gh/huggingface/transformers/pull/5307?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


Looks great!


That's awesome, thanks!
Fix LR decay in TF Trainer
Author: jplu
Pull request: yes

Revival of #5051

I have accidentally deleted the previous branch so I recreated this same one.

Comments:
@LysandreJik Sorry for the inconvenience :(

Will merge once the code quality passes

# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5269?src=pr&el=h1) Report
> Merging [#5269](https://codecov.io/gh/huggingface/transformers/pull/5269?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/0e1fce3c0129d05b65a83cdd89e8eadded553f2e&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `6.25%`.

[![Impacted file tree graph](https://codecov.io/gh/huggingface/transformers/pull/5269/graphs/tree.svg?width=650&height=150&src=pr&token=9qOlN6Hb1c)](https://codecov.io/gh/huggingface/transformers/pull/5269?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #5269      +/-   ##
==========================================
- Coverage   79.11%   79.03%   -0.08%     
==========================================
  Files         138      138              
  Lines       24080    24102      +22     
==========================================
- Hits        19050    19049       -1     
- Misses       5030     5053      +23     
```


| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5269?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/transformers/trainer\_tf.py](https://codecov.io/gh/huggingface/transformers/pull/5269/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy90cmFpbmVyX3RmLnB5) | `17.85% <6.25%> (-0.84%)` | :arrow_down: |
| [src/transformers/modeling\_openai.py](https://codecov.io/gh/huggingface/transformers/pull/5269/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ19vcGVuYWkucHk=) | `79.51% <0.00%> (-1.39%)` | :arrow_down: |
| [src/transformers/modeling\_tf\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5269/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `87.92% <0.00%> (+0.14%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5269?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5269?src=pr&el=footer). Last update [0e1fce3...78562e2](https://codecov.io/gh/huggingface/transformers/pull/5269?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


All tests are ok!
added subtitle for recent contributors in readme
Author: clmnt
Pull request: yes


Comments:
# [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5130?src=pr&el=h1) Report
> Merging [#5130](https://codecov.io/gh/huggingface/transformers/pull/5130?src=pr&el=desc) into [master](https://codecov.io/gh/huggingface/transformers/commit/84be482f6698fac822a5113735f2242c6d3abc76&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/huggingface/transformers/pull/5130/graphs/tree.svg?width=650&height=150&src=pr&token=9qOlN6Hb1c)](https://codecov.io/gh/huggingface/transformers/pull/5130?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master    #5130   +/-   ##
=======================================
  Coverage   77.19%   77.19%           
=======================================
  Files         133      133           
  Lines       22232    22232           
=======================================
  Hits        17162    17162           
  Misses       5070     5070           
```


| [Impacted Files](https://codecov.io/gh/huggingface/transformers/pull/5130?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/transformers/modeling\_tf\_utils.py](https://codecov.io/gh/huggingface/transformers/pull/5130/diff?src=pr&el=tree#diff-c3JjL3RyYW5zZm9ybWVycy9tb2RlbGluZ190Zl91dGlscy5weQ==) | `85.96% <0.00%> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/huggingface/transformers/pull/5130?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/huggingface/transformers/pull/5130?src=pr&el=footer). Last update [84be482...4341287](https://codecov.io/gh/huggingface/transformers/pull/5130?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


:shipit:
[Docs] Benchmark docs
Author: patrickvonplaten
Pull request: yes

This PR updates the docs for benchmarks and adds a README.md where the community can post their benchmark results. 

Would be happy about Feedback from @sgugger and @LysandreJik .

@LysandreJik - I deleted the part about "This work was done by [Timothy Liu](https://github.com/tlkh)." because the links were broken.

Comments:
Actually will make a separate PR for the examples README.md - to have the  docs in v3.0.0.

@sgugger right now it's not ignored, so the slow test will fail because the output isn't the same. I don't think it's too big of a deal though, we can fix that after the release with only partial testing of the file.

Thanks for the review. Addressed them and also renamed the classes for consistency.