Layoutlm tf
Author: atahmasb
Pull request: yes

# What does this PR do?

<!--
Congratulations! You've made it this far! You're not quite done yet though.

Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.

Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change.

Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost.
-->

<!-- Remove if not applicable -->

This PR adds TF version of LayoutLM for issue [(10312)](https://github.com/huggingface/transformers/issues/10312)


## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/master/CONTRIBUTING.md#start-contributing-pull-requests),
      Pull Request section?
- [X] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link
      to it if that's the case.
- [X] Did you make sure to update the documentation with your changes? Here are the
      [documentation guidelines](https://github.com/huggingface/transformers/tree/master/docs), and
      [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/master/docs#writing-source-documentation).
- [X] Did you write any new necessary tests?


## Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.

<!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @

 If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**.
 Please tag fewer than 3 people.

Models:

- albert, bert, xlm: @LysandreJik
- blenderbot, bart, marian, pegasus, encoderdecoder,  t5: @patrickvonplaten, @patil-suraj
- longformer, reformer, transfoxl, xlnet: @patrickvonplaten
- fsmt: @stas00
- funnel: @sgugger
- gpt2: @patrickvonplaten, @LysandreJik
- rag: @patrickvonplaten, @lhoestq
- tensorflow: @jplu

Library:

- benchmarks: @patrickvonplaten
- deepspeed: @stas00
- ray/raytune: @richardliaw, @amogkam
- text generation: @patrickvonplaten
- tokenizers: @n1t0, @LysandreJik
- trainer: @sgugger
- pipelines: @LysandreJik

Documentation: @sgugger

HF projects:

- nlp datasets: [different repo](https://github.com/huggingface/nlp)
- rust tokenizers: [different repo](https://github.com/huggingface/tokenizers)

Examples:

- maintained examples (not research project or legacy): @sgugger, @patil-suraj
- research_projects/bert-loses-patience: @JetRunner
- research_projects/distillation: @VictorSanh

 -->


Comments:
Very nice! Can you let us know when you want us to review/give feedback/help? Thanks!

> Very nice! Can you let us know when you want us to review/give feedback/help? Thanks!

thanks! I need to upload the TF model file to the hub and run another check to make sure it gives the same results as the PT version. I had verified that but I made few changes so I am gonna run the checks one  more time. I'll tag you when it's done

@LysandreJik I've uploaded TF models to the model hub under :
- atahmasb/tf-layoutlm-base-uncased
- atahmasb/tf-layoutlm-large-uncased

I appreciate if you and the team could take a look at the code and give me feedback.
There are some tests that are failing, I haven't figured the issues out but the code is up for review. Maybe someone could look into the logs and guide me on how to fix them.
Meanwhile I'll see if I can make the tests pass.

> Hi @atahmasb, this looks great! I've only left a few comments, everything looks good. I'll do a deeper review once all the tests pass, as things are bound to change until they do, but the idea here is sound!
> 
> Do you need any help to make the tests pass?

I am going to try one more time to resolve them today, if I can't then I'll ask for help

@LysandreJik all tests passed! It's ready for a deeper review please 

Thanks for letting me know! It seems GitHub botched your rebase, as it is showing 53 files changed. Could you close this PR and open a new one (no need to do anything on your branch) so that we may see the diff better?

Thanks! 

> Thanks for letting me know! It seems GitHub botched your rebase, as it is showing 53 files changed. Could you close this PR and open a new one (no need to do anything on your branch) so that we may see the diff better?
> 
> Thanks!

sure, will do